From 82907043eca37e40871f2e36a02241abb4d13804 Mon Sep 17 00:00:00 2001
From: Ivailo Monev <xakepa10@gmail.com>
Date: Tue, 12 Jan 2021 15:51:05 +0200
Subject: [PATCH] properly initialize and delete QImageWriterPrivate members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
---
 src/gui/image/qimagewriter.cpp | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/src/gui/image/qimagewriter.cpp b/src/gui/image/qimagewriter.cpp
index ac89d6200..75d823d6b 100644
--- a/src/gui/image/qimagewriter.cpp
+++ b/src/gui/image/qimagewriter.cpp
@@ -201,6 +201,7 @@ class QImageWriterPrivate
 {
 public:
     QImageWriterPrivate();
+    ~QImageWriterPrivate();
 
     // device
     QByteArray format;
@@ -222,15 +223,22 @@ public:
     \internal
 */
 QImageWriterPrivate::QImageWriterPrivate()
+    : device(Q_NULLPTR),
+    deleteDevice(false),
+    handler(Q_NULLPTR),
+    quality(-1),
+    compression(0),
+    gamma(0.0),
+    imageWriterError(QImageWriter::UnknownError),
+    errorString(QT_TRANSLATE_NOOP(QImageWriter, QLatin1String("Unknown error")))
 {
-    device = 0;
-    deleteDevice = false;
-    handler = 0;
-    quality = -1;
-    compression = 0;
-    gamma = 0.0;
-    imageWriterError = QImageWriter::UnknownError;
-    errorString = QT_TRANSLATE_NOOP(QImageWriter, QLatin1String("Unknown error"));
+}
+
+QImageWriterPrivate::~QImageWriterPrivate()
+{
+    if (deleteDevice)
+        delete device;
+    delete handler;
 }
 
 /*!
@@ -274,9 +282,6 @@ QImageWriter::QImageWriter(const QString &fileName, const QByteArray &format)
 */
 QImageWriter::~QImageWriter()
 {
-    if (d->deleteDevice)
-        delete d->device;
-    delete d->handler;
     delete d;
 }
 
-- 
2.11.0