From 82ce79999abf4899b10481209db7f0af8057a561 Mon Sep 17 00:00:00 2001 From: "Serge E. Hallyn" Date: Thu, 26 May 2011 15:25:05 -0500 Subject: [PATCH] Set cred->user_ns in key_replace_session_keyring MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit commit f7285b5d631fd6096b11c6af0058ed3a2b30ef4e upstream. Since this cred was not created with copy_creds(), it needs to get initialized. Otherwise use of syscall(__NR_keyctl, KEYCTL_SESSION_TO_PARENT); can lead to a NULL deref. Thanks to Robert for finding this. But introduced by commit 47a150edc2a ("Cache user_ns in struct cred"). Signed-off-by: Serge E. Hallyn Reported-by: Robert Święcki Cc: David Howells Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- security/keys/process_keys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c index 930634e45149..7a0c5868651f 100644 --- a/security/keys/process_keys.c +++ b/security/keys/process_keys.c @@ -845,6 +845,7 @@ void key_replace_session_keyring(void) new-> sgid = old-> sgid; new->fsgid = old->fsgid; new->user = get_uid(old->user); + new->user_ns = new->user->user_ns; new->group_info = get_group_info(old->group_info); new->securebits = old->securebits; -- 2.11.0