From 861ab99536bf1a7a3b15dd08c17b9047fc88014b Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Mon, 11 Jan 2016 12:33:23 -0800 Subject: [PATCH] Ignore Android.mk files with USE_SOONG=true When USE_SOONG=true, ignore any Android.mk file that has an Android.bp file in the same directory. Change-Id: Id79bd90c2aed5dafc2f8ad2c5b7eb0aa6e81dc18 --- core/definitions.mk | 26 ++++++++++++++++++++++---- core/main.mk | 5 +++-- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/core/definitions.mk b/core/definitions.mk index a6218cc45..05d850fec 100644 --- a/core/definitions.mk +++ b/core/definitions.mk @@ -142,11 +142,27 @@ $(strip \ endef ########################################################### +## Remove any makefiles that are being handled by soong +########################################################### +ifeq ($(USE_SOONG),true) +define filter-soong-makefiles +$(foreach mk,$(1),\ + $(if $(wildcard $(patsubst %/Android.mk,%/Android.bp,$(mk))),\ + $(info skipping $(mk) ...),\ + $(mk))) +endef +else +define filter-soong-makefiles +$(1) +endef +endif + +########################################################### ## Retrieve a list of all makefiles immediately below some directory ########################################################### define all-makefiles-under -$(sort $(wildcard $(1)/*/Android.mk)) +$(sort $(call filter-soong-makefiles,$(wildcard $(1)/*/Android.mk))) endef ########################################################### @@ -157,8 +173,9 @@ endef # $(1): directory to search under # Ignores $(1)/Android.mk define first-makefiles-under -$(shell build/tools/findleaves.py $(FIND_LEAVES_EXCLUDES) \ - --mindepth=2 $(1) Android.mk) +$(call filter-soong-makefiles,\ + $(shell build/tools/findleaves.py $(FIND_LEAVES_EXCLUDES) \ + --mindepth=2 $(1) Android.mk)) endef ########################################################### @@ -178,7 +195,8 @@ endef # $(1): List of directories to look for under this directory define all-named-subdir-makefiles -$(sort $(wildcard $(addsuffix /Android.mk, $(addprefix $(call my-dir)/,$(1))))) +$(sort $(call filter-soong-makefiles,\ + $(wildcard $(addsuffix /Android.mk, $(addprefix $(call my-dir)/,$(1)))))) endef ########################################################### diff --git a/core/main.mk b/core/main.mk index d2f8414f8..32b0b39f9 100644 --- a/core/main.mk +++ b/core/main.mk @@ -534,11 +534,12 @@ ifneq ($(dont_bother),true) # --mindepth=2 makes the prunes not work. subdir_makefiles := \ $(shell build/tools/findleaves.py $(FIND_LEAVES_EXCLUDES) $(subdirs) Android.mk) + ifeq ($(USE_SOONG),true) -subdir_makefiles := $(SOONG_ANDROID_MK) $(subdir_makefiles) +subdir_makefiles := $(SOONG_ANDROID_MK) $(call filter-soong-makefiles,$(subdir_makefiles)) endif -$(foreach mk, $(subdir_makefiles), $(info including $(mk) ...)$(eval include $(mk))) +$(foreach mk, $(subdir_makefiles),$(info including $(mk) ...)$(eval include $(mk))) endif # dont_bother -- 2.11.0