From 87689f70d66dc2559c19e60ab6f759874eeea56a Mon Sep 17 00:00:00 2001 From: Grace Kloba Date: Tue, 20 Oct 2009 16:08:58 -0700 Subject: [PATCH] Back in 02/08 when we added android_atomic_inc/dec, for some reason, it missed define WTF_USE_LOCKFREE_THREADSAFESHARED. So we are using mutexlocker instead of refcount inc/dec. Even mutex version should work, but it is not exercised by win/darwin/gcc. Changing to use refcount version fixed the crash seen in picasaweb. Fix http://b/issue?id=2183371 Maybe fix http://b/issue?id=2165237. But I can't verify as I can't reproduce it even before my change. --- JavaScriptCore/wtf/Threading.h | 1 + 1 file changed, 1 insertion(+) diff --git a/JavaScriptCore/wtf/Threading.h b/JavaScriptCore/wtf/Threading.h index bbfe8b51c..95a0603c5 100644 --- a/JavaScriptCore/wtf/Threading.h +++ b/JavaScriptCore/wtf/Threading.h @@ -235,6 +235,7 @@ inline void atomicIncrement(int volatile* addend) { OSAtomicIncrement32Barrier(c inline int atomicDecrement(int volatile* addend) { return OSAtomicDecrement32Barrier(const_cast(addend)); } #elif defined ANDROID +#define WTF_USE_LOCKFREE_THREADSAFESHARED 1 inline void atomicIncrement(int volatile* addend) { android_atomic_inc(addend); } inline int atomicDecrement(int volatile* addend) { return android_atomic_dec(addend); } -- 2.11.0