From 879ea7d34e7d15a1aa6a1fe375b307ab02c37808 Mon Sep 17 00:00:00 2001 From: Iulia Manda Date: Sat, 8 Mar 2014 18:05:36 +0200 Subject: [PATCH] Staging:vt6656: Replace some kzalloc calls with kcalloc in iwctl.c This replacement is justified by the fact that kcalloc could prevent integer overflow resulted from the multiplications used in kzalloc. The semantic patch that showed this suggestion is kzalloc.cocci Signed-off-by: Iulia Manda Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6656/iwctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c index 60264a655f24..bedc8104e835 100644 --- a/drivers/staging/vt6656/iwctl.c +++ b/drivers/staging/vt6656/iwctl.c @@ -725,10 +725,10 @@ int iwctl_giwaplist(struct net_device *dev, struct iw_request_info *info, if (!wrq->pointer) return -EINVAL; - sock = kzalloc(sizeof(struct sockaddr) * IW_MAX_AP, GFP_KERNEL); + sock = kcalloc(IW_MAX_AP, sizeof(struct sockaddr), GFP_KERNEL); if (sock == NULL) return -ENOMEM; - qual = kzalloc(sizeof(struct iw_quality) * IW_MAX_AP, GFP_KERNEL); + qual = kcalloc(IW_MAX_AP, sizeof(struct iw_quality), GFP_KERNEL); if (qual == NULL) { kfree(sock); return -ENOMEM; -- 2.11.0