From 8d731ebd33211d8b9c108fa60bfc854b2a8464c5 Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Sat, 31 Oct 2015 16:07:52 +1000 Subject: [PATCH] virgl: free sampler view on failure path Reported by Coverity. Signed-off-by: Dave Airlie --- src/gallium/drivers/virgl/virgl_context.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_context.c b/src/gallium/drivers/virgl/virgl_context.c index cae6352c0fe..e4f02ba1096 100644 --- a/src/gallium/drivers/virgl/virgl_context.c +++ b/src/gallium/drivers/virgl/virgl_context.c @@ -665,13 +665,17 @@ static struct pipe_sampler_view *virgl_create_sampler_view(struct pipe_context * const struct pipe_sampler_view *state) { struct virgl_context *vctx = virgl_context(ctx); - struct virgl_sampler_view *grview = CALLOC_STRUCT(virgl_sampler_view); + struct virgl_sampler_view *grview; uint32_t handle; struct virgl_resource *res; if (state == NULL) return NULL; + grview = CALLOC_STRUCT(virgl_sampler_view); + if (!grview) + return NULL; + res = virgl_resource(texture); handle = virgl_object_assign_handle(); virgl_encode_sampler_view(vctx, handle, res, state); -- 2.11.0