From 92e2ca32b551e69894b3fb09cdc863aef330b659 Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Mon, 1 Feb 2021 09:12:06 +0200 Subject: [PATCH] lock QFactoryLoader on write instead of read Signed-off-by: Ivailo Monev --- src/core/plugin/qfactoryloader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/plugin/qfactoryloader.cpp b/src/core/plugin/qfactoryloader.cpp index 185bf5d75..b0afc5bd6 100644 --- a/src/core/plugin/qfactoryloader.cpp +++ b/src/core/plugin/qfactoryloader.cpp @@ -185,6 +185,7 @@ void QFactoryLoader::updateDir(const QString &pluginDir) void QFactoryLoader::update() { Q_D(QFactoryLoader); + QMutexLocker locker(&d->mutex); foreach (const QString &pluginDir, QCoreApplication::libraryPaths()) { // Already loaded, skip it... if (d->loadedPaths.contains(pluginDir)) @@ -203,7 +204,6 @@ QFactoryLoader::~QFactoryLoader() QStringList QFactoryLoader::keys() const { Q_D(const QFactoryLoader); - QMutexLocker locker(&d->mutex); return d->keyList; } -- 2.11.0