From 93f2491cf832e3f4530fab8ce1755c2b501346ae Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 18 Jul 2009 18:49:04 +0000 Subject: [PATCH] add a fixme git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@76324 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Utils/InlineCost.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/Transforms/Utils/InlineCost.cpp b/lib/Transforms/Utils/InlineCost.cpp index 5fe85e6ef29..8925a752b19 100644 --- a/lib/Transforms/Utils/InlineCost.cpp +++ b/lib/Transforms/Utils/InlineCost.cpp @@ -45,6 +45,11 @@ unsigned InlineCostAnalyzer::FunctionInfo:: // We can't constant propagate instructions which have effects or // read memory. + // + // FIXME: It would be nice to capture the fact that a load from a + // pointer-to-constant-global is actually a *really* good thing to zap. + // Unfortunately, we don't know the pointer that may get propagated here, + // so we can't make this decision. if (Inst.mayReadFromMemory() || Inst.mayHaveSideEffects() || isa(Inst)) continue; -- 2.11.0