From 954515f73a0e2d3728be35ded497b71d26badf72 Mon Sep 17 00:00:00 2001 From: Hridya Valsaraju Date: Tue, 27 Sep 2016 13:43:57 -0700 Subject: [PATCH] Modify return values of read/write/config methods to bool Modify return values of read/write/config methods to bool for the FMQ unit tests and benchmarks. Bug: 31780470 Test: Built and ran existing FMQ unit tests and benchmarks Change-Id: I2b7c9cf073f0c1a2908d48552e258ce21240ae64 --- benchmarks/msgq/1.0/IBenchmarkMsgQ.hal | 17 +++++++++-------- tests/msgq/1.0/ITestMsgQ.hal | 14 ++++++++------ 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/benchmarks/msgq/1.0/IBenchmarkMsgQ.hal b/benchmarks/msgq/1.0/IBenchmarkMsgQ.hal index 2e503359..3af0b712 100644 --- a/benchmarks/msgq/1.0/IBenchmarkMsgQ.hal +++ b/benchmarks/msgq/1.0/IBenchmarkMsgQ.hal @@ -20,36 +20,37 @@ interface IBenchmarkMsgQ { /* * This method requests the service to set up Synchronous read/write * wait-free FMQ with the client as reader. - * @return ret Will be 0 if the setup is successful. + * @return ret Will be true if the setup was successful, false otherwise. * @return mqDescIn This structure describes the FMQ that was set up * by the service. Client can use it to set up the FMQ at its end. */ configureClientInboxSyncReadWrite() - generates(int32_t ret, MQDescriptorSync mqDescIn); + generates(bool ret, MQDescriptorSync mqDescIn); /* * This method requests the service to set up Synchronous read/write * wait-free FMQ with the client as writer. - * @return Will be 0 if the setup is successful. + * @return ret Will be true if the setup was successful, false otherwise. * @return mqDescOut This structure describes the FMQ that was set up * by the service. Client can use it to set up the FMQ at its end. */ configureClientOutboxSyncReadWrite() - generates(int32_t ret, MQDescriptorSync mqDescOut); + generates(bool ret, MQDescriptorSync mqDescOut); /* * This method request the service to write into the FMQ. * @param count Number to messages to write. - * @ret Number of messages succesfully written. + * @return ret Will be true if the write operation was successful, + * false otherwise. */ - requestWrite(int32_t count) generates (int32_t ret); + requestWrite(int32_t count) generates (bool ret); /* * This method request the service to read from the FMQ. * @param count Number to messages to read. - * @ret Number of messages succesfully read. + * @ret Will be true if the read operation was successful, false otherwise. */ - requestRead(int32_t count) generates (int32_t ret); + requestRead(int32_t count) generates (bool ret); /* * This method kicks off a benchmarking experiment where diff --git a/tests/msgq/1.0/ITestMsgQ.hal b/tests/msgq/1.0/ITestMsgQ.hal index 93a6e8a9..fc961815 100644 --- a/tests/msgq/1.0/ITestMsgQ.hal +++ b/tests/msgq/1.0/ITestMsgQ.hal @@ -20,24 +20,26 @@ interface ITestMsgQ { /* * This method requests the service to set up Synchronous read/write * wait-free FMQ with the client as reader. - * @return ret Will be 0 if the setup is successful. + * @return ret Will be true if the setup is successful, false otherwise. * @return mqDesc This structure describes the FMQ that was * set up by the service. Client can use it to set up the FMQ at its end. */ configureFmqSyncReadWrite() - generates(int32_t ret, MQDescriptorSync mqDesc); + generates(bool ret, MQDescriptorSync mqDesc); /* * This method request the service to write into the FMQ. * @param count Number to messages to write. - * @ret Number of messages succesfully written. + * @return ret Will be true if the write operation was successful, + * false otherwise. */ - requestWrite(int32_t count) generates(int32_t ret); + requestWrite(int32_t count) generates(bool ret); /* * This method request the service to read from the FMQ. * @param count Number to messages to read. - * @ret Number of messages succesfully read. + * @return ret Will be true if the read operation was successful, false + * otherwise. */ - requestRead(int32_t count) generates(int32_t ret); + requestRead(int32_t count) generates(bool ret); }; -- 2.11.0