From 95f589814c8af85fa673320bf319ffe8d721dd74 Mon Sep 17 00:00:00 2001 From: Ricky Liang Date: Mon, 18 May 2015 22:00:26 +0800 Subject: [PATCH] clk: mediatek: Initialize clk_init_data The variable init (struct clk_init_data) is allocated on the stack. We weren't initializing the .flags field, so it contains random junk, which can cause all kinds of interesting issues when the flags are parsed by clk_register. Signed-off-by: Ricky Liang Acked-by: Sascha Hauer Signed-off-by: Stephen Boyd --- drivers/clk/mediatek/clk-gate.c | 2 +- drivers/clk/mediatek/clk-pll.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c index 9d77ee3256f2..57020368a693 100644 --- a/drivers/clk/mediatek/clk-gate.c +++ b/drivers/clk/mediatek/clk-gate.c @@ -109,7 +109,7 @@ struct clk *mtk_clk_register_gate( { struct mtk_clk_gate *cg; struct clk *clk; - struct clk_init_data init; + struct clk_init_data init = {}; cg = kzalloc(sizeof(*cg), GFP_KERNEL); if (!cg) diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c index 66154caf992a..44409e98c52f 100644 --- a/drivers/clk/mediatek/clk-pll.c +++ b/drivers/clk/mediatek/clk-pll.c @@ -268,7 +268,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data, void __iomem *base) { struct mtk_clk_pll *pll; - struct clk_init_data init; + struct clk_init_data init = {}; struct clk *clk; const char *parent_name = "clk26m"; -- 2.11.0