From 965a06dbd7401fb319b6f85ca55c9687a05335f1 Mon Sep 17 00:00:00 2001 From: Ian Romanick Date: Mon, 2 Jul 2018 20:29:27 -0700 Subject: [PATCH] i965/vec4: Make the vec4_visitor::nir_emit_instr default case unreachable The bug fixed by the previous commit went undetected because extra stderr messages are not flagged by the CI. Copy the solution from fs_visitor::nir_emit_instr and mark the default case unreachable. An alternate solution is to delete the default case so that the compiler will issue a warning. That may require more work since there are other (impossible) cases that exist. Signed-off-by: Ian Romanick Reviewed-by: Jason Ekstrand --- src/intel/compiler/brw_vec4_nir.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/compiler/brw_vec4_nir.cpp b/src/intel/compiler/brw_vec4_nir.cpp index 7131fa06b4a..b77fa5fa821 100644 --- a/src/intel/compiler/brw_vec4_nir.cpp +++ b/src/intel/compiler/brw_vec4_nir.cpp @@ -169,8 +169,7 @@ vec4_visitor::nir_emit_instr(nir_instr *instr) break; default: - fprintf(stderr, "VS instruction not yet implemented by NIR->vec4\n"); - break; + unreachable("VS instruction not yet implemented by NIR->vec4"); } } -- 2.11.0