From 9703a9757a6119fc87b63b498e9b8ac58e96a9bd Mon Sep 17 00:00:00 2001 From: Ben Lin Date: Tue, 30 Jan 2018 15:39:18 -0800 Subject: [PATCH] Hide "Phone number" from About page if not call enabled. Bug: None Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.deviceinfo Change-Id: Ib056bae12d23fe68e71fe78c92741b8dc7887de0 --- .../deviceinfo/PhoneNumberPreferenceController.java | 2 +- .../deviceinfo/PhoneNumberPreferenceControllerTest.java | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/deviceinfo/PhoneNumberPreferenceController.java b/src/com/android/settings/deviceinfo/PhoneNumberPreferenceController.java index 93f75bfb32..4eb2ddd00a 100644 --- a/src/com/android/settings/deviceinfo/PhoneNumberPreferenceController.java +++ b/src/com/android/settings/deviceinfo/PhoneNumberPreferenceController.java @@ -58,7 +58,7 @@ public class PhoneNumberPreferenceController extends AbstractPreferenceControlle @Override public boolean isAvailable() { - return true; + return mTelephonyManager.isVoiceCapable(); } @Override diff --git a/tests/robotests/src/com/android/settings/deviceinfo/PhoneNumberPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/PhoneNumberPreferenceControllerTest.java index f30425bd21..0b83359f91 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/PhoneNumberPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/PhoneNumberPreferenceControllerTest.java @@ -16,6 +16,9 @@ package com.android.settings.deviceinfo; +import static junit.framework.Assert.assertFalse; +import static junit.framework.Assert.assertTrue; + import static org.mockito.ArgumentMatchers.anyInt; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.spy; @@ -74,6 +77,20 @@ public class PhoneNumberPreferenceControllerTest { } @Test + public void isAvailable_shouldBeTrueIfCallCapable() { + when(mTelephonyManager.isVoiceCapable()).thenReturn(true); + + assertTrue(mController.isAvailable()); + } + + @Test + public void isAvailable_shouldBeFalseIfNotCallCapable() { + when(mTelephonyManager.isVoiceCapable()).thenReturn(false); + + assertFalse(mController.isAvailable()); + } + + @Test public void displayPreference_multiSim_shouldAddSecondPreference() { when(mTelephonyManager.getPhoneCount()).thenReturn(2); -- 2.11.0