From 9a97ba700bc3242b380c245b53458ac6c90a320d Mon Sep 17 00:00:00 2001 From: Dan Willemsen Date: Thu, 5 May 2016 16:52:37 -0700 Subject: [PATCH] Only pass NINJA_ARGS to the main ninja compile This way commands like "-t query " will work against the main build, instead of failing to find the target during the initial soong build and stopping. Change-Id: I9b6bd6ac431b95e12db69ec7f272669b9d292761 --- core/ninja.mk | 10 +++++++--- core/soong.mk | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/core/ninja.mk b/core/ninja.mk index 8a94f3935..9e78c464a 100644 --- a/core/ninja.mk +++ b/core/ninja.mk @@ -104,13 +104,15 @@ ifeq (,$(NINJA_STATUS)) NINJA_STATUS := [%p %s/%t]$(space) endif +NINJA_EXTRA_ARGS := + ifneq (,$(filter showcommands,$(ORIGINAL_MAKECMDGOALS))) -NINJA_ARGS += "-v" +NINJA_EXTRA_ARGS += "-v" endif # Make multiple rules to generate the same target an error instead of # proceeding with undefined behavior. -NINJA_ARGS += -w dupbuild=err +NINJA_EXTRA_ARGS += -w dupbuild=err ifdef USE_GOMA KATI_MAKEPARALLEL := $(MAKEPARALLEL) @@ -118,11 +120,13 @@ KATI_MAKEPARALLEL := $(MAKEPARALLEL) # this parallelism. Note the parallelism of all other jobs is still # limited by the -j flag passed to GNU make. NINJA_REMOTE_NUM_JOBS ?= 500 -NINJA_ARGS += -j$(NINJA_REMOTE_NUM_JOBS) +NINJA_EXTRA_ARGS += -j$(NINJA_REMOTE_NUM_JOBS) else NINJA_MAKEPARALLEL := $(MAKEPARALLEL) --ninja endif +NINJA_ARGS += $(NINJA_EXTRA_ARGS) + ifeq ($(USE_SOONG),true) COMBINED_BUILD_NINJA := $(OUT_DIR)/combined$(KATI_NINJA_SUFFIX).ninja diff --git a/core/soong.mk b/core/soong.mk index 345069535..990a861d9 100644 --- a/core/soong.mk +++ b/core/soong.mk @@ -79,4 +79,4 @@ $(SOONG_IN_MAKE): # prebuilts. .PHONY: run_soong run_soong: $(SOONG_BOOTSTRAP) $(SOONG_VARIABLES) $(SOONG_IN_MAKE) FORCE - $(hide) $(SOONG) $(SOONG_BUILD_NINJA) $(NINJA_ARGS) + $(hide) $(SOONG) $(SOONG_BUILD_NINJA) $(NINJA_EXTRA_ARGS) -- 2.11.0