From 9b0d44ef678a1c1997213e3eb5cc68a11d4b3960 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Sat, 25 Oct 2008 15:00:28 +0000 Subject: [PATCH] Do not attempt to use the unscaled yuv2rgb converter when height is odd because it will overflow the buffer by 1 line. This might have been exploitable. Originally committed as revision 27826 to svn://svn.mplayerhq.hu/mplayer/trunk/libswscale --- libswscale/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index a926bade0..62c0548fd 100644 --- a/libswscale/swscale.c +++ b/libswscale/swscale.c @@ -2312,7 +2312,7 @@ SwsContext *sws_getContext(int srcW, int srcH, enum PixelFormat srcFormat, int d #ifdef CONFIG_GPL /* yuv2bgr */ if ((srcFormat==PIX_FMT_YUV420P || srcFormat==PIX_FMT_YUV422P) && (isBGR(dstFormat) || isRGB(dstFormat)) - && !(flags & SWS_ACCURATE_RND)) + && !(flags & SWS_ACCURATE_RND) && !(dstH&1)) { c->swScale= yuv2rgb_get_func_ptr(c); } -- 2.11.0