From 9c531a0f070b4f16b9dab34685a3687dbc98493a Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Mon, 1 Dec 2008 07:47:02 +0000 Subject: [PATCH] Move pattern check outside of the if-then statement. This prevents us from fiddling with constants unless we have to. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@60340 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/InstructionCombining.cpp | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index bc8744480c5..aae1e14f9db 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -2928,17 +2928,19 @@ Instruction *InstCombiner::visitSDiv(BinaryOperator &I) { if (RHS->isAllOnesValue()) return BinaryOperator::CreateNeg(Op0); - ConstantInt *RHSNeg = cast(ConstantExpr::getNeg(RHS)); - APInt RHSNegAPI(RHSNeg->getValue()); - - APInt NegOne = -APInt(RHSNeg->getBitWidth(), 1, true); - APInt TwoToExp(RHSNeg->getBitWidth(), 1 << (RHSNeg->getBitWidth() - 1)); - // -X/C -> X/-C, if and only if negation doesn't overflow. - if ((RHS->getValue().isNegative() && RHSNegAPI.slt(TwoToExp - 1)) || - (RHS->getValue().isNonNegative() && RHSNegAPI.sgt(TwoToExp * NegOne))) { - if (Value *LHSNeg = dyn_castNegVal(Op0)) { - if (ConstantInt *CI = dyn_cast(LHSNeg)) { + if (Value *LHSNeg = dyn_castNegVal(Op0)) { + if (ConstantInt *CI = dyn_cast(LHSNeg)) { + ConstantInt *RHSNeg = cast(ConstantExpr::getNeg(RHS)); + APInt RHSNegAPI(RHSNeg->getValue()); + + APInt NegOne = -APInt(RHSNeg->getBitWidth(), 1, true); + APInt TwoToExp(RHSNeg->getBitWidth(), 1 << (RHSNeg->getBitWidth() - 1)); + + if ((RHS->getValue().isNegative() && + RHSNegAPI.slt(TwoToExp - 1)) || + (RHS->getValue().isNonNegative() && + RHSNegAPI.sgt(TwoToExp * NegOne))) { ConstantInt *CINeg = cast(ConstantExpr::getNeg(CI)); APInt CINegAPI(CINeg->getValue()); -- 2.11.0