From 9c90e4ffabcb51d340648d71ada7208bc4e2de96 Mon Sep 17 00:00:00 2001
From: Cheng-Ru Lin <owenlin@google.com>
Date: Thu, 12 Nov 2009 11:48:46 +0800
Subject: [PATCH] Hide the indicator if the icon is empty.

Also change the order of on-screen icons.

http://b/issue?id=2250438

Change-Id: I25b0edfa1913aa3dacd960df87d5d7103e352bce
---
 res/layout/camera.xml                     | 49 +++++++++++++------------------
 res/layout/video_camera.xml               |  3 +-
 res/values/arrays.xml                     | 10 +++----
 res/values/styles.xml                     |  7 +++++
 src/com/android/camera/IconIndicator.java |  8 ++++-
 5 files changed, 40 insertions(+), 37 deletions(-)

diff --git a/res/layout/camera.xml b/res/layout/camera.xml
index 8984a0c..b35761c 100644
--- a/res/layout/camera.xml
+++ b/res/layout/camera.xml
@@ -40,50 +40,41 @@
                     android:id="@+id/focus_rectangle"
                     android:layout_width="fill_parent"
                     android:layout_height="fill_parent"/>
-            <com.android.camera.EvenlySpacedLayout android:id="@+id/indicator_bar"
-                    camera:orientation="vertical"
+            <LinearLayout android:id="@+id/indicator_bar"
+                    android:orientation="vertical"
                     android:visibility="visible"
-                    android:layout_gravity="left|fill_vertical"
-                    android:layout_marginTop="20dp"
+                    android:gravity="center"
+                    android:layout_gravity="left|top"
+                    android:layout_marginTop="10dp"
                     android:layout_marginLeft="10dp"
                     android:layout_width="wrap_content"
-                    android:layout_height="fill_parent">
+                    android:layout_height="wrap_content">
                 <com.android.camera.IconIndicator
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
+                        style="@style/IconIndicator"
                         android:id="@+id/gps_icon"
                         camera:modes="@array/gps_modes"
-                        camera:icons="@array/gps_icons"
-                        android:visibility="visible"/>
+                        camera:icons="@array/gps_icons"/>
                 <com.android.camera.IconIndicator
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
+                        style="@style/IconIndicator"
+                        android:id="@+id/scenemode_icon"
+                        camera:modes="@array/scenemode_modes"
+                        camera:icons="@array/scenemode_icons"/>
+                <com.android.camera.IconIndicator
+                        style="@style/IconIndicator"
                         android:id="@+id/focus_icon"
                         camera:modes="@array/pref_camera_focusmode_entryvalues"
-                        camera:icons="@array/focusmode_icons"
-                        android:visibility="visible"/>
+                        camera:icons="@array/focusmode_icons"/>
                 <com.android.camera.IconIndicator
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
+                        style="@style/IconIndicator"
                         android:id="@+id/whitebalance_icon"
                         camera:modes="@array/pref_camera_whitebalance_entryvalues"
-                        camera:icons="@array/whitebalance_icons"
-                        android:visibility="visible"/>
-                <com.android.camera.IconIndicator
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
-                        android:id="@+id/scenemode_icon"
-                        camera:modes="@array/scenemode_modes"
-                        camera:icons="@array/scenemode_icons"
-                        android:visibility="visible"/>
+                        camera:icons="@array/whitebalance_icons"/>
                 <com.android.camera.IconIndicator
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
+                        style="@style/IconIndicator"
                         android:id="@+id/flash_icon"
                         camera:modes="@array/pref_camera_flashmode_entryvalues"
-                        camera:icons="@array/flash_icons"
-                        android:visibility="visible"/>
-            </com.android.camera.EvenlySpacedLayout>
+                        camera:icons="@array/flash_icons"/>
+            </LinearLayout>
         </FrameLayout>
     </com.android.camera.PreviewFrameLayout>
 </LinearLayout>
diff --git a/res/layout/video_camera.xml b/res/layout/video_camera.xml
index 9ebdc03..b6717d8 100644
--- a/res/layout/video_camera.xml
+++ b/res/layout/video_camera.xml
@@ -71,8 +71,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content">
                 <com.android.camera.IconIndicator
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
+                        style="@style/IconIndicator"
                         android:id="@+id/whitebalance_icon"
                         camera:modes="@array/pref_camera_whitebalance_entryvalues"
                         camera:icons="@array/whitebalance_icons"/>
diff --git a/res/values/arrays.xml b/res/values/arrays.xml
index 53d9edb..77f9154 100644
--- a/res/values/arrays.xml
+++ b/res/values/arrays.xml
@@ -100,7 +100,7 @@
     </array>
 
     <array name="focusmode_icons">
-        <item>@drawable/ic_viewfinder_empty</item>
+        <item>@null</item>
         <item>@drawable/ic_viewfinder_focus_infinity</item>
         <item>@drawable/ic_viewfinder_focus_macro</item>
     </array>
@@ -137,7 +137,7 @@
     <array name="flash_icons">
         <item>@drawable/ic_viewfinder_flash_auto</item>
         <item>@drawable/ic_viewfinder_flash_on</item>
-        <item>@drawable/ic_viewfinder_empty</item>
+        <item>@null</item>
     </array>
 
     <string-array name="gps_modes" translatable="false">
@@ -146,7 +146,7 @@
     </string-array>
 
     <array name="gps_icons">
-        <item>0</item>
+        <item>@null</item>
         <item>@drawable/ic_camera_sym_gps</item>
     </array>
 
@@ -176,7 +176,7 @@
     </array>
 
     <array name="whitebalance_icons">
-        <item>@drawable/ic_viewfinder_empty</item>
+        <item>@null</item>
         <item>@drawable/ic_viewfinder_wb_incandescent</item>
         <item>@drawable/ic_viewfinder_wb_daylight</item>
         <item>@drawable/ic_viewfinder_wb_fluorescent</item>
@@ -251,7 +251,7 @@
     </string-array>
 
     <array name="scenemode_icons">
-        <item>@drawable/ic_viewfinder_empty</item>
+        <item>@null</item>
         <item>@drawable/ic_viewfinder_scenemode</item>
     </array>
 
diff --git a/res/values/styles.xml b/res/values/styles.xml
index ae5d16a..e18658d 100644
--- a/res/values/styles.xml
+++ b/res/values/styles.xml
@@ -78,6 +78,13 @@
         <item name="android:windowEnterAnimation">@null</item>
         <item name="android:windowExitAnimation">@null</item>
     </style>
+    <style name="IconIndicator">
+        <item name="android:visibility">gone</item>
+        <item name="android:layout_marginTop">10dp</item>
+        <item name="android:layout_marginBottom">10dp</item>
+        <item name="android:layout_width">wrap_content</item>
+        <item name="android:layout_height">wrap_content</item>
+    </style>
     <style name="CustomTheme"
            parent="@android:style/Theme.Black.NoTitleBar.Fullscreen">
         <item name="android:windowAnimationStyle">@style/NoEnterExitAnimation</item>
diff --git a/src/com/android/camera/IconIndicator.java b/src/com/android/camera/IconIndicator.java
index c3f0392..e4500e4 100644
--- a/src/com/android/camera/IconIndicator.java
+++ b/src/com/android/camera/IconIndicator.java
@@ -21,6 +21,7 @@ import android.content.res.Resources;
 import android.content.res.TypedArray;
 import android.graphics.drawable.Drawable;
 import android.util.AttributeSet;
+import android.view.View;
 import android.widget.ImageView;
 
 public class IconIndicator extends ImageView {
@@ -69,7 +70,12 @@ public class IconIndicator extends ImageView {
     public void setMode(String mode) {
         for (int i = 0, n = mModes.length; i < n; ++i) {
             if (mModes[i].equals(mode)) {
-                setImageDrawable(mIcons[i]);
+                if (mIcons[i] != null) {
+                    setVisibility(View.VISIBLE);
+                    setImageDrawable(mIcons[i]);
+                } else {
+                    setVisibility(View.GONE);
+                }
                 return;
             }
         }
-- 
2.11.0