From 9d03339b9c41b700fcc30e9d31f1d2ba844459fc Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Mon, 15 Feb 2021 02:50:54 +0200 Subject: [PATCH] mark some QProcessPrivate warning cases as unlikely Signed-off-by: Ivailo Monev --- src/core/io/qprocess_unix.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/io/qprocess_unix.cpp b/src/core/io/qprocess_unix.cpp index d57d5c2e5..fcca5edb0 100644 --- a/src/core/io/qprocess_unix.cpp +++ b/src/core/io/qprocess_unix.cpp @@ -307,7 +307,7 @@ static int qt_create_pipe(int *pipe) if (pipe[1] != -1) qt_safe_close(pipe[1]); int pipe_ret = qt_safe_pipe(pipe); - if (pipe_ret != 0) { + if (Q_UNLIKELY(pipe_ret != 0)) { qWarning("QProcessPrivate::createPipe: Cannot create pipe %p: %s", pipe, qPrintable(qt_error_string(errno))); } @@ -1163,7 +1163,7 @@ bool QProcessPrivate::startDetached(const QString &program, const QStringList &a qt_safe_close(startedPipe[1]); qt_safe_write(pidPipe[1], (const char *)&doubleForkPid, sizeof(pid_t)); - if (QT_CHDIR("/") == -1) { + if (Q_UNLIKELY(QT_CHDIR("/") == -1)) { qWarning("QProcessPrivate::startDetached: failed to chdir to /"); } ::_exit(1); -- 2.11.0