From 9d777508fa3b02aafdf365ee5398d2a0f4bf30ed Mon Sep 17 00:00:00 2001 From: Jason Garrett-Glaser Date: Tue, 26 Oct 2010 07:37:51 +0000 Subject: [PATCH] Remove dead code in theora_decode_tables Reading 7 bits as an unsigned int can't result in a value exceeding 127. Accordingly, remove error message (as it'll never be reached). Originally committed as revision 25575 to svn://svn.ffmpeg.org/ffmpeg/trunk --- libavcodec/vp3.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 36cfea2b4..3883512ca 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -2052,15 +2052,9 @@ static int theora_decode_tables(AVCodecContext *avctx, GetBitContext *gb) if (s->theora >= 0x030200) { n = get_bits(gb, 3); /* loop filter limit values table */ - if (n) { - for (i = 0; i < 64; i++) { + if (n) + for (i = 0; i < 64; i++) s->filter_limit_values[i] = get_bits(gb, n); - if (s->filter_limit_values[i] > 127) { - av_log(avctx, AV_LOG_ERROR, "filter limit value too large (%i > 127), clamping\n", s->filter_limit_values[i]); - s->filter_limit_values[i] = 127; - } - } - } } if (s->theora >= 0x030200) -- 2.11.0