From a1b60e629f529111fbcd3b853774f3b3603b7831 Mon Sep 17 00:00:00 2001 From: Jerry Zhang Date: Wed, 12 Oct 2016 14:42:56 -0700 Subject: [PATCH] Refactor setCurrentFunction and setUsbDataUnlocked into one method This allows us to get rid of an extraneous config switch and simplify some code. Test: Manually change usb configuration Change-Id: Id78da530ff485ecd7a915056832eec1dd8c91954 (cherry picked from commit 5d36a177d95184aaa0763d07aa38ff028f5a9b9c) --- src/com/android/settings/DevelopmentSettings.java | 5 ++--- src/com/android/settings/deviceinfo/UsbBackend.java | 12 ++++-------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/com/android/settings/DevelopmentSettings.java b/src/com/android/settings/DevelopmentSettings.java index 714f7d0a99..5e18493ede 100644 --- a/src/com/android/settings/DevelopmentSettings.java +++ b/src/com/android/settings/DevelopmentSettings.java @@ -1704,11 +1704,10 @@ public class DevelopmentSettings extends RestrictedSettingsFragment private void writeUsbConfigurationOption(Object newValue) { UsbManager manager = (UsbManager)getActivity().getSystemService(Context.USB_SERVICE); String function = newValue.toString(); - manager.setCurrentFunction(function); if (function.equals("none")) { - manager.setUsbDataUnlocked(false); + manager.setCurrentFunction(function, false); } else { - manager.setUsbDataUnlocked(true); + manager.setCurrentFunction(function, true); } } diff --git a/src/com/android/settings/deviceinfo/UsbBackend.java b/src/com/android/settings/deviceinfo/UsbBackend.java index cd887093fe..e648b39382 100644 --- a/src/com/android/settings/deviceinfo/UsbBackend.java +++ b/src/com/android/settings/deviceinfo/UsbBackend.java @@ -101,20 +101,16 @@ public class UsbBackend { private void setUsbFunction(int mode) { switch (mode) { case MODE_DATA_MTP: - mUsbManager.setCurrentFunction(UsbManager.USB_FUNCTION_MTP); - mUsbManager.setUsbDataUnlocked(true); + mUsbManager.setCurrentFunction(UsbManager.USB_FUNCTION_MTP, true); break; case MODE_DATA_PTP: - mUsbManager.setCurrentFunction(UsbManager.USB_FUNCTION_PTP); - mUsbManager.setUsbDataUnlocked(true); + mUsbManager.setCurrentFunction(UsbManager.USB_FUNCTION_PTP, true); break; case MODE_DATA_MIDI: - mUsbManager.setCurrentFunction(UsbManager.USB_FUNCTION_MIDI); - mUsbManager.setUsbDataUnlocked(true); + mUsbManager.setCurrentFunction(UsbManager.USB_FUNCTION_MIDI, true); break; default: - mUsbManager.setCurrentFunction(null); - mUsbManager.setUsbDataUnlocked(false); + mUsbManager.setCurrentFunction(null, false); break; } } -- 2.11.0