From a272803ec587c13747ccbe841ab5312c87c97087 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Sat, 2 Aug 2014 00:50:10 +0000 Subject: [PATCH] [x86] Make some questionable tests not spew assembly to stdout, which makes a mess of the lit output when they ultimately fail. The 2012-10-02-DAGCycle test is really frustrating because the *only* explanation for what it is testing is a rdar link. I would really rather that rdar links (which are not public or part of the open source project) were not committed to the source code. Regardless, the actual problem *must* be described as the rdar link is completely opaque. The fact that this test didn't check for any particular output further exacerbates the inability of any other developer to debug failures. The mem-promote-integers test has nice comments and *seems* to be a great test for our lowering... except that we don't actually check that any of the generated code is correct or matches some pattern. We just avoid crashing. It would be great to go back and populate this test with the actual expectations. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214605 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/CodeGen/X86/2012-10-02-DAGCycle.ll | 4 ++-- test/CodeGen/X86/mem-promote-integers.ll | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/CodeGen/X86/2012-10-02-DAGCycle.ll b/test/CodeGen/X86/2012-10-02-DAGCycle.ll index 8d914db3315..403d21ae973 100644 --- a/test/CodeGen/X86/2012-10-02-DAGCycle.ll +++ b/test/CodeGen/X86/2012-10-02-DAGCycle.ll @@ -1,5 +1,5 @@ -; RUN: llc -mtriple=i386-apple-macosx -relocation-model=pic < %s -; RUN: llc -mtriple=x86_64-apple-macosx -relocation-model=pic < %s +; RUN: llc -mtriple=i386-apple-macosx -relocation-model=pic < %s > /dev/null +; RUN: llc -mtriple=x86_64-apple-macosx -relocation-model=pic < %s > /dev/null ; rdar://12393897 diff --git a/test/CodeGen/X86/mem-promote-integers.ll b/test/CodeGen/X86/mem-promote-integers.ll index 0015df0c1fa..ea38b95a864 100644 --- a/test/CodeGen/X86/mem-promote-integers.ll +++ b/test/CodeGen/X86/mem-promote-integers.ll @@ -1,8 +1,8 @@ ; Test the basic functionality of integer element promotions of different types. ; This tests checks passing of arguments, loading and storing to memory and ; basic arithmetic. -; RUN: llc -march=x86 < %s -; RUN: llc -march=x86-64 < %s +; RUN: llc -march=x86 < %s > /dev/null +; RUN: llc -march=x86-64 < %s > /dev/null define <1 x i8> @test_1xi8(<1 x i8> %x, <1 x i8>* %b) { %bb = load <1 x i8>* %b -- 2.11.0