From a3dc1fb0b7f236012fc82360c18c063bb4fc8f69 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Tue, 12 Apr 2016 10:25:12 -0400 Subject: [PATCH] Remove category from managedservices. Bug: 27976092 Change-Id: Ic6303b95fc6d612e83f3a42a933ae94bd7c17255 --- .../server/notification/ManagedServices.java | 60 ---------------------- .../notification/NotificationManagerService.java | 2 +- 2 files changed, 1 insertion(+), 61 deletions(-) diff --git a/services/core/java/com/android/server/notification/ManagedServices.java b/services/core/java/com/android/server/notification/ManagedServices.java index 6d9fed46102b..c31d93e9fe1d 100644 --- a/services/core/java/com/android/server/notification/ManagedServices.java +++ b/services/core/java/com/android/server/notification/ManagedServices.java @@ -97,8 +97,6 @@ abstract public class ManagedServices { // List of packages in restored setting across all mUserProfiles, for quick // filtering upon package updates. private ArraySet mRestoredPackages = new ArraySet<>(); - // State of current service categories - private ArrayMap mCategoryEnabled = new ArrayMap<>(); // List of enabled packages that have nevertheless asked not to be run private ArraySet mSnoozingForCurrentProfiles = new ArraySet<>(); @@ -342,47 +340,6 @@ abstract public class ManagedServices { } } - public void setCategoryState(String category, boolean enabled) { - synchronized (mMutex) { - final Boolean previous = mCategoryEnabled.put(category, enabled); - if (!(previous == null || previous != enabled)) { - return; - } - - // State changed - if (DEBUG) { - Slog.d(TAG, ((enabled) ? "Enabling " : "Disabling ") + "category " + category); - } - - final int[] userIds = mUserProfiles.getCurrentProfileIds(); - for (int userId : userIds) { - final Set componentNames = queryPackageForServices(null, - userId, category); - - // Disallow services not enabled in Settings - final ArraySet userComponents = - loadComponentNamesFromSetting(mConfig.secureSettingName, userId); - if (userComponents == null) { - componentNames.clear(); - } else { - componentNames.retainAll(userComponents); - } - - if (DEBUG) { - Slog.d(TAG, "Components for category " + category + ": " + componentNames); - } - for (ComponentName c : componentNames) { - if (enabled) { - registerServiceLocked(c, userId); - } else { - unregisterServiceLocked(c, userId); - } - } - } - - } - } - private void rebuildRestoredPackages() { mRestoredPackages.clear(); mSnoozingForCurrentProfiles.clear(); @@ -454,20 +411,12 @@ abstract public class ManagedServices { } protected Set queryPackageForServices(String packageName, int userId) { - return queryPackageForServices(packageName, userId, null); - } - - public Set queryPackageForServices(String packageName, int userId, - String category) { Set installed = new ArraySet<>(); final PackageManager pm = mContext.getPackageManager(); Intent queryIntent = new Intent(mConfig.serviceInterface); if (!TextUtils.isEmpty(packageName)) { queryIntent.setPackage(packageName); } - if (category != null) { - queryIntent.addCategory(category); - } List installedServices = pm.queryIntentServicesAsUser( queryIntent, PackageManager.GET_SERVICES | PackageManager.GET_META_DATA, @@ -578,15 +527,6 @@ abstract public class ManagedServices { } final Set add = new HashSet<>(userComponents); - - // Remove components from disabled categories so that those services aren't run. - for (Entry e : mCategoryEnabled.entrySet()) { - if (!e.getValue()) { - Set c = queryPackageForServices(null, userIds[i], - e.getKey()); - add.removeAll(c); - } - } add.removeAll(mSnoozingForCurrentProfiles); toAdd.put(userIds[i], add); diff --git a/services/core/java/com/android/server/notification/NotificationManagerService.java b/services/core/java/com/android/server/notification/NotificationManagerService.java index f75711d41a86..a3ffb426b87f 100644 --- a/services/core/java/com/android/server/notification/NotificationManagerService.java +++ b/services/core/java/com/android/server/notification/NotificationManagerService.java @@ -3851,7 +3851,7 @@ public class NotificationManagerService extends SystemService { return; } Set rankerComponents = queryPackageForServices( - mRankerServicePackageName, UserHandle.USER_SYSTEM, null); + mRankerServicePackageName, UserHandle.USER_SYSTEM); Iterator iterator = rankerComponents.iterator(); if (iterator.hasNext()) { ComponentName rankerComponent = iterator.next(); -- 2.11.0