From a497696338f966bc048be0af8cfc6da52c7129c2 Mon Sep 17 00:00:00 2001
From: Ivailo Monev <xakepa10@laimg.moc>
Date: Fri, 7 Jun 2019 13:40:38 +0000
Subject: [PATCH] compiler warning fixes

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
---
 src/core/thread/qmutexpool.cpp                            | 2 +-
 src/declarative/util/qdeclarativelistmodelworkeragent_p.h | 5 ++++-
 src/gui/itemviews/qitemdelegate.cpp                       | 4 ----
 src/gui/widgets/qprintpreviewwidget.cpp                   | 3 ---
 src/plugins/accessible/widgets/itemviews.cpp              | 6 +++---
 5 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/src/core/thread/qmutexpool.cpp b/src/core/thread/qmutexpool.cpp
index 180693691..3ae2df1e1 100644
--- a/src/core/thread/qmutexpool.cpp
+++ b/src/core/thread/qmutexpool.cpp
@@ -104,7 +104,7 @@ QMutexPool::QMutexPool(QMutex::RecursionMode recursionMode)
 */
 QMutexPool::~QMutexPool()
 {
-    for (int index = 0; index < mutexes.size(); ++index) {
+    for (int index = 0; index < QMUTEXPOOL_SIZE; ++index) {
         delete mutexes[index];
         mutexes[index] = Q_NULLPTR;
     }
diff --git a/src/declarative/util/qdeclarativelistmodelworkeragent_p.h b/src/declarative/util/qdeclarativelistmodelworkeragent_p.h
index 0770613e1..42d473fed 100644
--- a/src/declarative/util/qdeclarativelistmodelworkeragent_p.h
+++ b/src/declarative/util/qdeclarativelistmodelworkeragent_p.h
@@ -96,7 +96,10 @@ public:
 
         VariantRef &operator=(const VariantRef &o) { 
             if (o.a) o.a->addref(); 
-            if (a) a->release(); a = o.a; 
+            if (a) {
+                a->release();
+                a = o.a;
+            }
             return *this; 
         }
 
diff --git a/src/gui/itemviews/qitemdelegate.cpp b/src/gui/itemviews/qitemdelegate.cpp
index 6e708fc84..3adfda26f 100644
--- a/src/gui/itemviews/qitemdelegate.cpp
+++ b/src/gui/itemviews/qitemdelegate.cpp
@@ -765,7 +765,6 @@ void QItemDelegate::drawFocus(QPainter *painter,
                               const QStyleOptionViewItem &option,
                               const QRect &rect) const
 {
-    Q_D(const QItemDelegate);
     if ((option.state & QStyle::State_HasFocus) == 0 || !rect.isValid())
         return;
     QStyleOptionFocusRect o;
@@ -791,7 +790,6 @@ void QItemDelegate::drawCheck(QPainter *painter,
                               const QStyleOptionViewItem &option,
                               const QRect &rect, Qt::CheckState state) const
 {
-    Q_D(const QItemDelegate);
     if (!rect.isValid())
         return;
 
@@ -856,7 +854,6 @@ void QItemDelegate::doLayout(const QStyleOptionViewItem &option,
                              bool hint) const
 {
     Q_ASSERT(checkRect && pixmapRect && textRect);
-    Q_D(const QItemDelegate);
     QStyle *style = option.widget ? option.widget->style() : QApplication::style();
     const bool hasCheck = checkRect->isValid();
     const bool hasPixmap = pixmapRect->isValid();
@@ -1110,7 +1107,6 @@ QRect QItemDelegate::check(const QStyleOptionViewItem &option,
                            const QRect &bounding, const QVariant &value) const
 {
     if (value.isValid()) {
-        Q_D(const QItemDelegate);
         QStyleOptionButton opt;
         opt.QStyleOption::operator=(option);
         opt.rect = bounding;
diff --git a/src/gui/widgets/qprintpreviewwidget.cpp b/src/gui/widgets/qprintpreviewwidget.cpp
index b393e5da5..7a02990a3 100644
--- a/src/gui/widgets/qprintpreviewwidget.cpp
+++ b/src/gui/widgets/qprintpreviewwidget.cpp
@@ -54,7 +54,6 @@
 
 QT_BEGIN_NAMESPACE
 
-namespace {
 class PageItem : public QGraphicsItem
 {
 public:
@@ -170,8 +169,6 @@ protected:
     }
 };
 
-} // anonymous namespace
-
 class QPrintPreviewWidgetPrivate : public QWidgetPrivate
 {
     Q_DECLARE_PUBLIC(QPrintPreviewWidget)
diff --git a/src/plugins/accessible/widgets/itemviews.cpp b/src/plugins/accessible/widgets/itemviews.cpp
index f4c839fbc..d4ea60cdf 100644
--- a/src/plugins/accessible/widgets/itemviews.cpp
+++ b/src/plugins/accessible/widgets/itemviews.cpp
@@ -831,12 +831,12 @@ QRect QAccessibleTable2Cell::rect(int child) const
 {
     Q_ASSERT(child == 0);
 
-    QRect r;
-    r = view->visualRect(m_index);
+    QRect r = view->visualRect(m_index);
 
-    if (!r.isNull())
+    if (!r.isNull()) {
         r.translate(view->viewport()->mapTo(view, QPoint(0,0)));
         r.translate(view->mapToGlobal(QPoint(0, 0)));
+    }
     return r;
 }
 
-- 
2.11.0