From aa04f11f4acc4b5f9cbcf35d5ba2cc795080c25f Mon Sep 17 00:00:00 2001 From: Jan Vesely Date: Sat, 18 Feb 2017 04:24:10 +0000 Subject: [PATCH] AMDGPU/R600: Assert on infinite loop in EmitClauseMarkers Differential Revision: https://reviews.llvm.org/D29792 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@295539 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/AMDGPU/R600EmitClauseMarkers.cpp | 8 +++++--- test/CodeGen/AMDGPU/r600.alu-limits.ll | 28 ++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 3 deletions(-) create mode 100644 test/CodeGen/AMDGPU/r600.alu-limits.ll diff --git a/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp b/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp index ceb5870a349..81c2152cb89 100644 --- a/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp +++ b/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp @@ -321,9 +321,11 @@ public: if (I != MBB.end() && I->getOpcode() == AMDGPU::CF_ALU) continue; // BB was already parsed for (MachineBasicBlock::iterator E = MBB.end(); I != E;) { - if (isALU(*I)) - I = MakeALUClause(MBB, I); - else + if (isALU(*I)) { + auto next = MakeALUClause(MBB, I); + assert(next != I); + I = next; + } else ++I; } } diff --git a/test/CodeGen/AMDGPU/r600.alu-limits.ll b/test/CodeGen/AMDGPU/r600.alu-limits.ll new file mode 100644 index 00000000000..648fe0489a9 --- /dev/null +++ b/test/CodeGen/AMDGPU/r600.alu-limits.ll @@ -0,0 +1,28 @@ +; RUN: opt -loop-unroll -unroll-threshold=2000 -S < %s | llc -march=r600 -mcpu=cypress | FileCheck %s +; XFAIL: * + +; CHECK: {{^}}@alu_limits: + +%struct.foo = type {i32, i32, i32} + +define void @alu_limits(i32 addrspace(1)* %out, %struct.foo* %in, i32 %offset) { +entry: + %ptr = getelementptr inbounds %struct.foo, %struct.foo* %in, i32 1, i32 2 + %x = load i32, i32 *%ptr, align 4 + br label %loop +loop: + %i = phi i32 [ 100, %entry ], [ %nexti, %loop ] + %val = phi i32 [ 1, %entry ], [ %nextval, %loop ] + + %nexti = sub i32 %i, 1 + + %y = xor i32 %x, %i + %nextval = mul i32 %val, %y + + %cond = icmp ne i32 %nexti, 0 + br i1 %cond, label %loop, label %end +end: + %out_val = add i32 %nextval, 4 + store i32 %out_val, i32 addrspace(1)* %out, align 4 + ret void +} -- 2.11.0