From aaf9a5b0ccb502d17fa83a119e69baec1af76d1a Mon Sep 17 00:00:00 2001 From: Ying Wang Date: Thu, 9 Apr 2015 09:22:36 -0700 Subject: [PATCH] Remove ancient ranlib workaround on Mac OS X. Apparently we don't need it for Mac OS X 10.7 and above. Change-Id: I5ee81700c16e8c66b2d5f2b373fd2d523b5ec018 --- core/combo/HOST_darwin-x86.mk | 8 +------- core/combo/HOST_darwin-x86_64.mk | 5 ----- core/definitions.mk | 26 -------------------------- core/prebuilt_internal.mk | 7 ------- 4 files changed, 1 insertion(+), 45 deletions(-) diff --git a/core/combo/HOST_darwin-x86.mk b/core/combo/HOST_darwin-x86.mk index 7fa48fffc..8389bb83f 100644 --- a/core/combo/HOST_darwin-x86.mk +++ b/core/combo/HOST_darwin-x86.mk @@ -56,12 +56,6 @@ $(combo_2nd_arch_prefix)HOST_JNILIB_SUFFIX := .jnilib $(combo_2nd_arch_prefix)HOST_GLOBAL_CFLAGS += \ -include $(call select-android-config-h,darwin-x86) -ifneq ($(filter 10.7 10.7.% 10.8 10.8.%, $(build_mac_version)),) - $(combo_2nd_arch_prefix)HOST_RUN_RANLIB_AFTER_COPYING := false -else - $(combo_2nd_arch_prefix)HOST_RUN_RANLIB_AFTER_COPYING := true - PRE_LION_DYNAMIC_LINKER_OPTIONS := -Wl,-dynamic -endif $(combo_2nd_arch_prefix)HOST_GLOBAL_ARFLAGS := cqs ############################################################ @@ -91,7 +85,7 @@ define transform-host-o-to-executable-inner $(hide) $(PRIVATE_CXX) \ -Wl,-rpath,@loader_path/../$(notdir $($(PRIVATE_2ND_ARCH_VAR_PREFIX)HOST_OUT_SHARED_LIBRARIES)) \ -o $@ \ - $(PRE_LION_DYNAMIC_LINKER_OPTIONS) -Wl,-headerpad_max_install_names \ + -Wl,-headerpad_max_install_names \ $($(PRIVATE_2ND_ARCH_VAR_PREFIX)HOST_GLOBAL_LD_DIRS) \ $(if $(PRIVATE_NO_DEFAULT_COMPILER_FLAGS),, \ $(PRIVATE_HOST_GLOBAL_LDFLAGS) \ diff --git a/core/combo/HOST_darwin-x86_64.mk b/core/combo/HOST_darwin-x86_64.mk index c06933d2d..0efa78fe5 100644 --- a/core/combo/HOST_darwin-x86_64.mk +++ b/core/combo/HOST_darwin-x86_64.mk @@ -55,11 +55,6 @@ HOST_JNILIB_SUFFIX := .jnilib HOST_GLOBAL_CFLAGS += \ -include $(call select-android-config-h,darwin-x86) -ifneq ($(filter 10.7 10.7.% 10.8 10.8.%, $(build_mac_version)),) - HOST_RUN_RANLIB_AFTER_COPYING := false -else - HOST_RUN_RANLIB_AFTER_COPYING := true -endif HOST_GLOBAL_ARFLAGS := cqs # We Reuse the following functions with the same name from HOST_darwin-x86.mk: diff --git a/core/definitions.mk b/core/definitions.mk index e56e0db7f..4f0daae5f 100644 --- a/core/definitions.mk +++ b/core/definitions.mk @@ -2091,32 +2091,6 @@ $(foreach t,$(1),\ $(hide) mkdir -p $(dir $(3)/$(s)); cp -Rf $(t) $(3)/$(s)$(newline)) endef -########################################################### -## On some platforms (MacOS), after copying a static -## library, ranlib must be run to update an internal -## timestamp!?!?! -########################################################### - -ifeq ($(HOST_RUN_RANLIB_AFTER_COPYING),true) -define transform-host-ranlib-copy-hack - $(hide) ranlib $@ || true -endef -else -define transform-host-ranlib-copy-hack -@true -endef -endif - -ifeq ($(TARGET_RUN_RANLIB_AFTER_COPYING),true) -define transform-ranlib-copy-hack - $(hide) ranlib $@ -endef -else -define transform-ranlib-copy-hack -@true -endef -endif - ########################################################### ## Commands to call Proguard diff --git a/core/prebuilt_internal.mk b/core/prebuilt_internal.mk index 47e21ef0d..d5446190e 100644 --- a/core/prebuilt_internal.mk +++ b/core/prebuilt_internal.mk @@ -256,13 +256,6 @@ $(built_module) : $(my_prebuilt_src_file) else $(built_module) : $(my_prebuilt_src_file) | $(ACP) $(transform-prebuilt-to-target) -ifneq ($(prebuilt_module_is_a_library),) - ifneq ($(LOCAL_IS_HOST_MODULE),) - $(transform-host-ranlib-copy-hack) - else - $(transform-ranlib-copy-hack) - endif -endif endif endif # LOCAL_MODULE_CLASS != APPS -- 2.11.0