From acf5ff297ec60ae4205927fcc860325e638e42ac Mon Sep 17 00:00:00 2001 From: Lyude Paul Date: Fri, 19 Feb 2021 16:53:07 -0500 Subject: [PATCH] drm/bridge/analogix/anx6345: Don't link encoder until after connector registration Another case of linking an encoder to a connector after the connector's been registered. The proper place to do this is before connector registration, so let's fix that. Signed-off-by: Lyude Paul Reviewed-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20210219215326.2227596-12-lyude@redhat.com --- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index 8e016ba7c54a..6258f16da0e8 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c @@ -556,12 +556,6 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge, drm_connector_helper_add(&anx6345->connector, &anx6345_connector_helper_funcs); - err = drm_connector_register(&anx6345->connector); - if (err) { - DRM_ERROR("Failed to register connector: %d\n", err); - return err; - } - anx6345->connector.polled = DRM_CONNECTOR_POLL_HPD; err = drm_connector_attach_encoder(&anx6345->connector, @@ -571,6 +565,12 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge, return err; } + err = drm_connector_register(&anx6345->connector); + if (err) { + DRM_ERROR("Failed to register connector: %d\n", err); + return err; + } + return 0; } -- 2.11.0