From ae56a2ff92ac73782279abf8857585c34b15f509 Mon Sep 17 00:00:00 2001 From: "Emilio G. Cota" Date: Sat, 9 Feb 2019 11:27:44 -0500 Subject: [PATCH] exec-all: document that tlb_fill can trigger a TLB resize Signed-off-by: Emilio G. Cota Message-Id: <20190209162745.12668-2-cota@braap.org> Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index aa7b81aaf0..97b90cb0db 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -475,6 +475,11 @@ static inline void assert_no_pages_locked(void) struct MemoryRegionSection *iotlb_to_section(CPUState *cpu, hwaddr index, MemTxAttrs attrs); +/* + * Note: tlb_fill() can trigger a resize of the TLB. This means that all of the + * caller's prior references to the TLB table (e.g. CPUTLBEntry pointers) must + * be discarded and looked up again (e.g. via tlb_entry()). + */ void tlb_fill(CPUState *cpu, target_ulong addr, int size, MMUAccessType access_type, int mmu_idx, uintptr_t retaddr); -- 2.11.0