From ae8dff9cb70f4a32fd0da14dab63916b673d2c3b Mon Sep 17 00:00:00 2001 From: Asutosh Das Date: Mon, 5 Dec 2016 11:41:40 +0530 Subject: [PATCH] phy: qcom-ufs: Modify the vdd-phy min-max range There are 2 issues with setting the vdd-phy voltage: 1. The min & max range that's defined is 1v, whereas 0.925 (+/- 5%) is the required voltage. A range of 0.8v to 0.925v would suffice. 2. This defined range is over-ridden with the current rail-voltage. This assumes that some consumer has set the regulator to the correct voltage. This change corrects the defined min/max range to 0.8v-0.925v for vdd-phy. It also removes the code that's causing [2]. CRs-fixed: 1095116 Change-Id: I943bc4f38385036b21c1f9a2e479d6e94ac12813 Signed-off-by: Asutosh Das --- drivers/phy/phy-qcom-ufs.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c index e0cab3a683d6..6e06fef81849 100644 --- a/drivers/phy/phy-qcom-ufs.c +++ b/drivers/phy/phy-qcom-ufs.c @@ -15,8 +15,8 @@ #include "phy-qcom-ufs-i.h" #define MAX_PROP_NAME 32 -#define VDDA_PHY_MIN_UV 1000000 -#define VDDA_PHY_MAX_UV 1000000 +#define VDDA_PHY_MIN_UV 800000 +#define VDDA_PHY_MAX_UV 925000 #define VDDA_PLL_MIN_UV 1200000 #define VDDA_PLL_MAX_UV 1800000 #define VDDP_REF_CLK_MIN_UV 1200000 @@ -239,7 +239,6 @@ ufs_qcom_phy_init_vregulators(struct phy *generic_phy, struct ufs_qcom_phy *phy_common) { int err; - int vdda_phy_uV; err = ufs_qcom_phy_init_vreg(generic_phy, &phy_common->vdda_pll, "vdda-pll"); @@ -251,10 +250,6 @@ ufs_qcom_phy_init_vregulators(struct phy *generic_phy, if (err) goto out; - vdda_phy_uV = regulator_get_voltage(phy_common->vdda_phy.reg); - phy_common->vdda_phy.max_uV = vdda_phy_uV; - phy_common->vdda_phy.min_uV = vdda_phy_uV; - /* vddp-ref-clk-* properties are optional */ __ufs_qcom_phy_init_vreg(generic_phy, &phy_common->vddp_ref_clk, "vddp-ref-clk", true); -- 2.11.0