From b003364bc7e31e7f85865ef298d399ed61c372a2 Mon Sep 17 00:00:00 2001 From: Jaewan Kim Date: Fri, 22 Apr 2016 18:41:37 +0900 Subject: [PATCH] Revert "Prevent recents from closing while moving PiP to fullscreen." This reverts commit 744e6e3aef4d4b6cb3a75e8ecbbc1796da2388b2 to prevent Recents from shown again after an activity is PIPed immediately after the fullscreen. Bug: 28333917 Change-Id: Ifeceb910eefc3eef109bdc3ed24e11109f2cf9b4 --- packages/SystemUI/src/com/android/systemui/tv/pip/PipManager.java | 8 +++----- .../java/com/android/server/wm/BoundsAnimationController.java | 8 ++------ 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/tv/pip/PipManager.java b/packages/SystemUI/src/com/android/systemui/tv/pip/PipManager.java index d7efca7cac50..5febb9b52a31 100644 --- a/packages/SystemUI/src/com/android/systemui/tv/pip/PipManager.java +++ b/packages/SystemUI/src/com/android/systemui/tv/pip/PipManager.java @@ -276,6 +276,9 @@ public class PipManager { void movePipToFullscreen() { mState = STATE_NO_PIP; mPipTaskId = TASK_ID_NO_PIP; + for (int i = mListeners.size() - 1; i >= 0; --i) { + mListeners.get(i).onMoveToFullscreen(); + } resizePinnedStack(mState); } @@ -635,11 +638,6 @@ public class PipManager { public void onPinnedStackAnimationEnded() { if (DEBUG) Log.d(TAG, "onPinnedStackAnimationEnded()"); switch (mState) { - case STATE_NO_PIP: - for (int i = mListeners.size() - 1; i >= 0; --i) { - mListeners.get(i).onMoveToFullscreen(); - } - break; case STATE_PIP_OVERLAY: if (!mPipRecentsOverlayManager.isRecentsShown()) { showPipOverlay(); diff --git a/services/core/java/com/android/server/wm/BoundsAnimationController.java b/services/core/java/com/android/server/wm/BoundsAnimationController.java index 1f44b2971e24..debb38257817 100644 --- a/services/core/java/com/android/server/wm/BoundsAnimationController.java +++ b/services/core/java/com/android/server/wm/BoundsAnimationController.java @@ -149,15 +149,11 @@ public class BoundsAnimationController { public void onAnimationEnd(Animator animation) { if (DEBUG) Slog.d(TAG, "onAnimationEnd: mTarget=" + mTarget + " mMoveToFullScreen=" + mMoveToFullScreen + " mWillReplace=" + mWillReplace); + + finishAnimation(); if (mMoveToFullScreen && !mWillReplace) { mTarget.moveToFullscreen(); } - - // If we finish the animation before we move the target to fullscreen, - // recents may close itself and we may try and resume the previous - // fullscreen app leading to churn and flicker after we then move - // our target to fullscreen. - finishAnimation(); } @Override -- 2.11.0