From b1a235f9524b71126a9768571ad0b0a7fe0b304c Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Tue, 9 Feb 2016 12:57:02 -0500 Subject: [PATCH] Importance slider logging. Change-Id: I3c4ad73d1460e4d28cb1a10846159128590d2b20 --- .../src/com/android/systemui/statusbar/NotificationGuts.java | 7 +++++++ proto/src/metrics_constants.proto | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/NotificationGuts.java b/packages/SystemUI/src/com/android/systemui/statusbar/NotificationGuts.java index 5abd1d5c4b03..dd6d6f381c02 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/NotificationGuts.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/NotificationGuts.java @@ -35,6 +35,8 @@ import android.widget.RadioButton; import android.widget.SeekBar; import android.widget.TextView; +import com.android.internal.logging.MetricsLogger; +import com.android.internal.logging.MetricsProto.MetricsEvent; import com.android.settingslib.Utils; import com.android.systemui.R; @@ -51,6 +53,7 @@ public class NotificationGuts extends LinearLayout { private SeekBar mSeekBar; private Notification.Topic mTopic; private INotificationManager mINotificationManager; + private int mStartingImportance; public NotificationGuts(Context context, AttributeSet attrs) { super(context, attrs); @@ -103,6 +106,7 @@ public class NotificationGuts extends LinearLayout { void bindImportance(final StatusBarNotification sbn, final ExpandableNotificationRow row, final int importance) { + mStartingImportance = importance; mINotificationManager = INotificationManager.Stub.asInterface( ServiceManager.getService(Context.NOTIFICATION_SERVICE)); mTopic = sbn.getNotification().getTopic() == null @@ -151,6 +155,7 @@ public class NotificationGuts extends LinearLayout { } updateTitleAndSummary(progress); if (fromUser) { + MetricsLogger.action(mContext, MetricsEvent.ACTION_MODIFY_IMPORTANCE_SLIDER); if (appUsesTopics) { mApplyToTopic.setVisibility(View.VISIBLE); mApplyToTopic.setText( @@ -205,6 +210,8 @@ public class NotificationGuts extends LinearLayout { void saveImportance(final StatusBarNotification sbn) { int progress = mSeekBar.getProgress(); + MetricsLogger.action(mContext, MetricsEvent.ACTION_SAVE_IMPORTANCE, + progress - mStartingImportance); try { mINotificationManager.setImportance(sbn.getPackageName(), sbn.getUid(), mApplyToTopic.isChecked() ? mTopic : null, progress); diff --git a/proto/src/metrics_constants.proto b/proto/src/metrics_constants.proto index 439be812aab1..3f3f851acfb5 100644 --- a/proto/src/metrics_constants.proto +++ b/proto/src/metrics_constants.proto @@ -362,5 +362,12 @@ message MetricsEvent { // Logged when a user dismisses a task in overview OVERVIEW_DISMISS = 289; + + // Logged when the user modifying the notification importance slider. + ACTION_MODIFY_IMPORTANCE_SLIDER = 290; + + // Logged when the user saves a modification to notification importance. Negative numbers + // indicate the user lowered the importance; positive means they increased it. + ACTION_SAVE_IMPORTANCE = 291; } } -- 2.11.0