From b1dd9f0c4c618723a85e799fd38bf4ce9885ba32 Mon Sep 17 00:00:00 2001 From: Alan Kwong Date: Fri, 13 May 2016 09:42:55 -0400 Subject: [PATCH] msm: sde: Correct resource release upon rotator exit This patch turns off clock and bus control as well releases other software resources upon driver exit. This patch corrects crash due to resource leakage. CRs-Fixed: 1018309 Change-Id: Ie0c6639fff9b829a58e12037f88c6508864b60a0 Signed-off-by: Alan Kwong --- drivers/media/platform/msm/sde/rotator/sde_rotator_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/msm/sde/rotator/sde_rotator_core.c b/drivers/media/platform/msm/sde/rotator/sde_rotator_core.c index 28748ec2d6e0..f5799c7f86fd 100644 --- a/drivers/media/platform/msm/sde/rotator/sde_rotator_core.c +++ b/drivers/media/platform/msm/sde/rotator/sde_rotator_core.c @@ -2423,13 +2423,15 @@ int sde_rotator_core_init(struct sde_rot_mgr **pmgr, error_init_queue: mgr->ops_hw_destroy(mgr); error_hw_init: +error_map_hw_ops: + sde_rotator_clk_ctrl(mgr, false); + sde_rotator_resource_ctrl(mgr, false); pm_runtime_disable(mgr->device); sde_rotator_res_destroy(mgr); error_res_init: error_parse_dt: sysfs_remove_group(&mgr->device->kobj, &sde_rotator_fs_attr_group); error_create_sysfs: -error_map_hw_ops: devm_kfree(&pdev->dev, mgr); *pmgr = NULL; return ret; -- 2.11.0