From b41ea09975ebcafbf9cfdaa2b19069c08ed91fc7 Mon Sep 17 00:00:00 2001 From: Michael Curran Date: Wed, 20 Jan 2016 15:05:32 +1000 Subject: [PATCH] Fixed problems with braille display output when entering Korean characters. NVDAHelper.handleInputCompositionStart: the new input composition NVDAObject's parent is set to the most correct focus (i.e. objectWithFocus). However, if this is equal to NVDA's focus object, use that instead, in order to still maintain any possible state. Fixes #5640. --- source/NVDAHelper.py | 3 +++ user_docs/en/changes.t2t | 1 + 2 files changed, 4 insertions(+) diff --git a/source/NVDAHelper.py b/source/NVDAHelper.py index ed03d9f97..dfa2652a4 100755 --- a/source/NVDAHelper.py +++ b/source/NVDAHelper.py @@ -163,6 +163,9 @@ def handleInputCompositionStart(compositionString,selectionStart,selectionEnd,is return 0 if not isinstance(focus,InputComposition): parent=api.getDesktopObject().objectWithFocus() + # #5640: Although we want to use the most correct focus (I.e. OS, not NVDA), if they are the same, we definitely want to use the original instance, so that state such as auto selection is maintained. + if parent==focus: + parent=focus curInputComposition=InputComposition(parent=parent) oldSpeechMode=speech.speechMode speech.speechMode=speech.speechMode_off diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t index c2f6cc62a..a94edad86 100644 --- a/user_docs/en/changes.t2t +++ b/user_docs/en/changes.t2t @@ -49,6 +49,7 @@ Highlights of this release include the ability to optionally lower the volume of - In Google Chrome, navigating within an Input composition when entering east Asian characters now works as expected. (#4080) - When searching Apple Music in iTunes, browse mode for the search results document is now updated as expected. (#5659) - In Microsoft Excel, pressing shift+f11 to create a new sheet now reports your new position instead of reporting nothing. (#5689) +- Fixed problems with braille display output when entering Korean characters. (#5640) == Changes for Developers == -- 2.11.0