From b423f726267635f6dfea55d9d612afa99ec8dc51 Mon Sep 17 00:00:00 2001 From: linus_lee Date: Wed, 3 Sep 2014 19:48:29 -0700 Subject: [PATCH] Eleven: lots of ui tweaks (fonts, padding, grid layout) and cancel tasks smarter Change-Id: Ifffd2ef386c301d546d4182bc5c3bf303194021c --- AndroidManifest.xml | 2 +- res/drawable-hdpi/cardcontainer.9.png | Bin 0 -> 227 bytes res/drawable-mdpi/cardcontainer.9.png | Bin 0 -> 172 bytes res/drawable-xhdpi/cardcontainer.9.png | Bin 0 -> 293 bytes res/drawable-xxhdpi/cardcontainer.9.png | Bin 0 -> 345 bytes res/layout/edit_queue_list_item.xml | 4 +- res/layout/fragment_music_browser_phone.xml | 1 + res/layout/fragment_themes_base.xml | 47 --------------------- res/layout/grid_base.xml | 4 +- res/layout/grid_items_normal.xml | 22 ++++------ res/layout/header_bar.xml | 1 + res/layout/list_header.xml | 3 +- res/layout/list_item_normal.xml | 2 +- res/layout/list_item_queue.xml | 31 ++++++-------- res/values/arrays.xml | 4 +- res/values/colors.xml | 3 +- res/values/dimens.xml | 8 +++- res/values/strings.xml | 2 + res/values/styles.xml | 23 ++++++++-- res/values/vpi__attrs.xml | 2 + res/values/vpi__defaults.xml | 1 + .../eleven/adapters/AlbumArtPagerAdapter.java | 6 +++ src/com/cyngn/eleven/adapters/ArtistAdapter.java | 15 +++++-- src/com/cyngn/eleven/adapters/PagerAdapter.java | 12 +----- src/com/cyngn/eleven/adapters/SongAdapter.java | 42 +++++++++++++++--- src/com/cyngn/eleven/cache/ImageWorker.java | 18 ++++++++ src/com/cyngn/eleven/loaders/AlbumSongLoader.java | 2 +- src/com/cyngn/eleven/loaders/ArtistSongLoader.java | 17 +++++--- src/com/cyngn/eleven/loaders/GenreSongLoader.java | 2 +- src/com/cyngn/eleven/loaders/LastAddedLoader.java | 19 ++++++--- src/com/cyngn/eleven/loaders/NowPlayingCursor.java | 6 ++- .../cyngn/eleven/loaders/PlaylistSongLoader.java | 12 ++++-- src/com/cyngn/eleven/loaders/QueueLoader.java | 11 +++-- src/com/cyngn/eleven/loaders/SearchLoader.java | 10 +++-- src/com/cyngn/eleven/loaders/SongLoader.java | 17 +++++--- src/com/cyngn/eleven/model/Song.java | 12 +++++- src/com/cyngn/eleven/ui/HeaderBar.java | 12 ++++++ .../cyngn/eleven/ui/activities/HomeActivity.java | 43 +++++++++++++++++++ .../cyngn/eleven/ui/fragments/ArtistFragment.java | 2 +- .../eleven/ui/fragments/AudioPlayerFragment.java | 2 +- .../cyngn/eleven/ui/fragments/SongFragment.java | 32 +++++++++++++- .../fragments/phone/MusicBrowserPhoneFragment.java | 22 ++++------ src/com/viewpagerindicator/TitlePageIndicator.java | 16 ++++++- 43 files changed, 324 insertions(+), 166 deletions(-) create mode 100644 res/drawable-hdpi/cardcontainer.9.png create mode 100644 res/drawable-mdpi/cardcontainer.9.png create mode 100644 res/drawable-xhdpi/cardcontainer.9.png create mode 100644 res/drawable-xxhdpi/cardcontainer.9.png delete mode 100644 res/layout/fragment_themes_base.xml diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 3a4fc9f..fe80222 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -20,7 +20,7 @@ diff --git a/res/drawable-hdpi/cardcontainer.9.png b/res/drawable-hdpi/cardcontainer.9.png new file mode 100644 index 0000000000000000000000000000000000000000..246064e87b465c9d78387cf834bcc7060eeaff56 GIT binary patch literal 227 zcmV<90382`P)#Dj69WnTa*%|NsAg=g*zfo|TbS1IwMp*}1va zfkDBhOw7y#4f^-@@89+7)}Ed^dGb-9rDtG=q^5#gGDKs7Ib_yRD6{ec-m derf}jH2@~2R04gbi@5**002ovPDHLkV1m^tUy1+# literal 0 HcmV?d00001 diff --git a/res/drawable-mdpi/cardcontainer.9.png b/res/drawable-mdpi/cardcontainer.9.png new file mode 100644 index 0000000000000000000000000000000000000000..2e6032b3d091fc681b5aa4d55e51e914849ddd32 GIT binary patch literal 172 zcmeAS@N?(olHy`uVBq!ia0vp^JRr=$1|-8uW1a)4Vow*x5RKsElmmSKoLeO?E>$m~$5msSlW@QE= X12d+WSd+Iv>lr*<{an^LB{Ts5w3I{? literal 0 HcmV?d00001 diff --git a/res/drawable-xhdpi/cardcontainer.9.png b/res/drawable-xhdpi/cardcontainer.9.png new file mode 100644 index 0000000000000000000000000000000000000000..e019df03387c24c23697ee6857d15247a6bcd264 GIT binary patch literal 293 zcmV+=0owkFP)GaFU>Xeycxs_}Q2Ym`V}fau6a_FB)6C$} zoJWTY^8NR}zl@BGOr*p-F17#v|NqCy%ESaN-5x)CbwgB4RGk_Izkc=lrmU2hI@sX0 zwvMXog2D=RHa1>L4FCD-*XOAd`a7zsDq6t?b8v9j*4EbB#U&=kiinD+k{T=^@4tEd z=Julba~C%^Hy--&r?7bbzP>i$ z8;n43vU~daSuX1X7=GHB8R_I7ZsRRZu$AgxGe_p@xp(`_qO6%xDl0PsuWr!{&SUz! zPxcuDvx2*rgiuniu56&!DKD`rWgI6SRhPe?yJG#y2(~XjwHMU(H~z3W!?=JYgZ;>w zDaUjt{;FrbD$8{3VEjbusWlFc+Ex}!DL)Mr{;`xCsQ(hDtD$nGA)<+mk1_HOQ%64I mNAmy=MeBrwC>0)_9){+nOBnY2 diff --git a/res/layout/fragment_music_browser_phone.xml b/res/layout/fragment_music_browser_phone.xml index c461c79..d62ffc2 100644 --- a/res/layout/fragment_music_browser_phone.xml +++ b/res/layout/fragment_music_browser_phone.xml @@ -30,6 +30,7 @@ android:layout_width="match_parent" android:layout_height="@dimen/tpi_height" android:textColor="@color/tpi_text_color" + tpi:boldAll="true" tpi:selectedColor="@color/tpi_selected_text_color" tpi:footerLineHeight="@dimen/tpi_footer_line_height" tpi:footerIndicatorHeight="@dimen/tpi_footer_indicator_height" diff --git a/res/layout/fragment_themes_base.xml b/res/layout/fragment_themes_base.xml deleted file mode 100644 index d9b9584..0000000 --- a/res/layout/fragment_themes_base.xml +++ /dev/null @@ -1,47 +0,0 @@ - - - - - - - - - - - - \ No newline at end of file diff --git a/res/layout/grid_base.xml b/res/layout/grid_base.xml index 3b51674..ad38b92 100644 --- a/res/layout/grid_base.xml +++ b/res/layout/grid_base.xml @@ -40,9 +40,9 @@ android:drawSelectorOnTop="true" android:fadingEdge="vertical" android:fastScrollEnabled="true" - android:horizontalSpacing="@dimen/grid_item_spacing" + android:horizontalSpacing="@dimen/grid_item_horizontal_spacing" android:scrollbarStyle="outsideOverlay" android:scrollbars="vertical" - android:verticalSpacing="@dimen/grid_item_spacing" /> + android:verticalSpacing="@dimen/grid_item_vertical_spacing" /> \ No newline at end of file diff --git a/res/layout/grid_items_normal.xml b/res/layout/grid_items_normal.xml index 69c447d..f61af9a 100644 --- a/res/layout/grid_items_normal.xml +++ b/res/layout/grid_items_normal.xml @@ -16,37 +16,31 @@ --> + android:layout_alignParentTop="true" /> + android:layout_below="@+id/line_one" /> \ No newline at end of file diff --git a/res/layout/header_bar.xml b/res/layout/header_bar.xml index 6230573..b83a818 100644 --- a/res/layout/header_bar.xml +++ b/res/layout/header_bar.xml @@ -28,6 +28,7 @@ android:layout_weight="1" android:ellipsize="end" android:singleLine="true" + android:textAllCaps="true" android:textColor="@color/header_action_bar_text_color" android:textSize="@dimen/text_size_large" /> diff --git a/res/layout/list_header.xml b/res/layout/list_header.xml index f10aa90..aff83b4 100644 --- a/res/layout/list_header.xml +++ b/res/layout/list_header.xml @@ -21,4 +21,5 @@ android:background="@null" android:gravity="center_vertical" android:textColor="@color/list_item_header_text_color" - android:textSize="@dimen/list_item_header_size" /> + android:textSize="@dimen/list_item_header_size" + android:fontFamily="sans-serif-light" /> diff --git a/res/layout/list_item_normal.xml b/res/layout/list_item_normal.xml index ee34ec9..775ec1f 100644 --- a/res/layout/list_item_normal.xml +++ b/res/layout/list_item_normal.xml @@ -30,7 +30,7 @@ android:layout_height="@dimen/list_item_image_height" android:layout_alignParentLeft="true" android:layout_alignParentTop="true" - android:scaleType="fitXY" /> + android:scaleType="centerCrop" /> + android:minHeight="@dimen/item_normal_height" + android:paddingTop="@dimen/list_item_padding_top" + android:paddingBottom="@dimen/list_item_padding_bottom"> + + - - - - \ No newline at end of file diff --git a/res/values/arrays.xml b/res/values/arrays.xml index c9f3bde..258950e 100644 --- a/res/values/arrays.xml +++ b/res/values/arrays.xml @@ -19,12 +19,10 @@ - @string/page_playlists - @string/page_recent @string/page_artists @string/page_albums @string/page_songs - @string/page_genres + @string/page_playlists diff --git a/res/values/colors.xml b/res/values/colors.xml index bbbee0d..3d57335 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -64,7 +64,7 @@ #ff31353f @color/white - @color/white + @color/default_text_color_light @@ -77,6 +77,7 @@ @color/default_text_color @color/default_text_color_light #4c231f20 + #cc231f20 #fff4f4f4 diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 72d0749..92aeb23 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -37,26 +37,30 @@ 16.0sp 14.0sp 12.0sp + 15.0dip 8.0dip 8.0dip - 4.0dip + 4.0dip + 6.0dip 120.0dip 8.0dip 8.0dip + + 40dip 70.0dip 50.0dip 50.0dip - 48.0dip + 50.0dip 56.0dip 12.0dip 12.0dip diff --git a/res/values/strings.xml b/res/values/strings.xml index 108994e..02f0614 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -194,4 +194,6 @@ 1 Album %d Albums 5+ Albums + + %1$s | %2$s diff --git a/res/values/styles.xml b/res/values/styles.xml index 30bd95b..9aa37a0 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -53,12 +53,14 @@ @@ -88,6 +90,7 @@ @@ -96,10 +99,16 @@ true + + @@ -107,6 +116,10 @@ true + + @@ -170,18 +183,22 @@ wrap_content end 5dp + 16dp top|left|center true - true @color/bottom_action_bar_text_color - @dimen/text_size_extra_micro - +