From b4657e00115d0c87970a2386338b70fa95ef4ac6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Uwe=20Kleine-K=C3=B6nig?= Date: Thu, 31 Mar 2022 14:31:32 +0100 Subject: [PATCH] media: i2c: dw9714: Return zero in remove callback MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The only effect of returning an error code in an i2c remove callback is that the i2c core emits a generic warning and still removes the device. So even if disabling the regulator fails it's sensible to further cleanup and then return zero to only emit a single error message. This patch is a preparation for making i2c remove callbacks return void. Signed-off-by: Uwe Kleine-König Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/dw9714.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c index 8c5797ba57d4..206d74338b9c 100644 --- a/drivers/media/i2c/dw9714.c +++ b/drivers/media/i2c/dw9714.c @@ -202,7 +202,6 @@ static int dw9714_remove(struct i2c_client *client) if (ret) { dev_err(&client->dev, "Failed to disable vcc: %d\n", ret); - return ret; } } pm_runtime_set_suspended(&client->dev); -- 2.11.0