From b9adbd998f266c9b5694947700743f93161d9c7a Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Mon, 20 Jul 2015 03:01:49 +0000 Subject: [PATCH] Refactor duplicated code. NFC. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242655 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/llvm-readobj/llvm-readobj.cpp | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tools/llvm-readobj/llvm-readobj.cpp b/tools/llvm-readobj/llvm-readobj.cpp index 12afacb0a85..39d2e1c3342 100644 --- a/tools/llvm-readobj/llvm-readobj.cpp +++ b/tools/llvm-readobj/llvm-readobj.cpp @@ -190,15 +190,19 @@ namespace opts { static int ReturnValue = EXIT_SUCCESS; +static void reportError(Twine Msg) { + ReturnValue = EXIT_FAILURE; + outs() << Msg << "\n"; + outs().flush(); +} + namespace llvm { bool error(std::error_code EC) { if (!EC) return false; - ReturnValue = EXIT_FAILURE; - outs() << "\nError reading file: " << EC.message() << ".\n"; - outs().flush(); + reportError(Twine("\nError reading file: ") + EC.message() + "."); return true; } @@ -212,17 +216,14 @@ static void reportError(StringRef Input, std::error_code EC) { if (Input == "-") Input = ""; - errs() << Input << ": " << EC.message() << "\n"; - errs().flush(); - ReturnValue = EXIT_FAILURE; + reportError(Twine(Input) + ": " + EC.message()); } static void reportError(StringRef Input, StringRef Message) { if (Input == "-") Input = ""; - errs() << Input << ": " << Message << "\n"; - ReturnValue = EXIT_FAILURE; + reportError(Twine(Input) + ": " + Message); } static bool isMipsArch(unsigned Arch) { -- 2.11.0