From c0e8cf4810a164a15d419b0c42dd83117430ebe5 Mon Sep 17 00:00:00 2001 From: ezannoni Date: Mon, 26 Mar 2001 02:50:46 +0000 Subject: [PATCH] 2001-03-25 Elena Zannoni From Andrew Cagney * coffread.c: Include "gdb_assert.h". (coff_symtab_read): Cast the integer s_sclass to a long before casting it to a pointer. --- gdb/ChangeLog | 8 ++++++++ gdb/coffread.c | 11 +++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 38efd9f4c0..f8538bdd83 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,6 +1,14 @@ 2001-03-25 Elena Zannoni From Andrew Cagney + + * coffread.c: Include "gdb_assert.h". + (coff_symtab_read): Cast the integer s_sclass to a long before + casting it to a pointer. + +2001-03-25 Elena Zannoni + + From Andrew Cagney * coffread.c (coff_symtab_read): Initialize ``fcn_first_line_addr''. Check that the ``.bf'' always preceeds diff --git a/gdb/coffread.c b/gdb/coffread.c index 7f775de49f..a343a6825d 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -43,6 +43,7 @@ #include "stabsread.h" #include "complaints.h" #include "target.h" +#include "gdb_assert.h" extern void _initialize_coffread (void); @@ -966,9 +967,15 @@ coff_symtab_read (long symtab_offset, unsigned int nsyms, { struct minimal_symbol *msym; + /* FIXME: cagney/2001-02-01: The nasty (int) -> (long) + -> (void*) cast is to ensure that that the value of + cs->c_sclass can be correctly stored in a void + pointer in MSYMBOL_INFO. Better solutions + welcome. */ + gdb_assert (sizeof (void *) >= sizeof (cs->c_sclass)); msym = prim_record_minimal_symbol_and_info - (cs->c_name, tmpaddr, ms_type, (char *) cs->c_sclass, sec, - NULL, objfile); + (cs->c_name, tmpaddr, ms_type, (void *) (long) cs->c_sclass, + sec, NULL, objfile); #ifdef COFF_MAKE_MSYMBOL_SPECIAL if (msym) COFF_MAKE_MSYMBOL_SPECIAL (cs->c_sclass, msym); -- 2.11.0