From c33e4b59c48aff4c531ba33d03066b0fe101b8bf Mon Sep 17 00:00:00 2001 From: Eino-Ville Talvala Date: Tue, 11 Sep 2012 16:51:32 -0700 Subject: [PATCH] Camera2: Configure ZSL at the right time. ZSL enable was too early in the camera startup sequence, resulting it being turned off most of the time. Bug: 7148012 Change-Id: Ie144dd960d018a34b0bc77c88208ca22b7112772 --- services/camera/libcameraservice/Camera2Client.cpp | 9 --------- services/camera/libcameraservice/camera2/Parameters.cpp | 10 +++++++++- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/services/camera/libcameraservice/Camera2Client.cpp b/services/camera/libcameraservice/Camera2Client.cpp index 4237afb774..eb72412fe0 100644 --- a/services/camera/libcameraservice/Camera2Client.cpp +++ b/services/camera/libcameraservice/Camera2Client.cpp @@ -64,15 +64,6 @@ Camera2Client::Camera2Client(const sp& cameraService, SharedParameters::Lock l(mParameters); l.mParameters.state = Parameters::DISCONNECTED; - - char value[PROPERTY_VALUE_MAX]; - property_get("camera.zsl_mode", value, "0"); - if (!strcmp(value,"1")) { - ALOGI("Camera %d: Enabling ZSL mode", cameraId); - l.mParameters.zslMode = true; - } else { - l.mParameters.zslMode = false; - } } status_t Camera2Client::checkPid(const char* checkLocation) const { diff --git a/services/camera/libcameraservice/camera2/Parameters.cpp b/services/camera/libcameraservice/camera2/Parameters.cpp index f490b2a50c..c07a6ac098 100644 --- a/services/camera/libcameraservice/camera2/Parameters.cpp +++ b/services/camera/libcameraservice/camera2/Parameters.cpp @@ -23,6 +23,7 @@ #include #include +#include #include "Parameters.h" #include "system/camera.h" @@ -748,7 +749,14 @@ status_t Parameters::initialize(const CameraMetadata *info) { previewCallbackFlags = 0; - zslMode = false; + char value[PROPERTY_VALUE_MAX]; + property_get("camera.zsl_mode", value, "0"); + if (!strcmp(value,"1")) { + ALOGI("Camera %d: Enabling ZSL mode", cameraId); + zslMode = true; + } else { + zslMode = false; + } lightFx = LIGHTFX_NONE; -- 2.11.0