From c42b4bb097c6a89bd9016bcbeed08a436d591d27 Mon Sep 17 00:00:00 2001 From: Dimitry Ivanov Date: Wed, 3 May 2017 11:01:00 -0700 Subject: [PATCH] Remove known failures from arm ifunc tests Since clang does not produce IRELATIVE relocations this test started passing when we switched away from gcc This is still a problem because it now leads to situation where static ifuncs become globally visible but this is a different problem. Test: bionic-unit-tests --gtest_filer=dl* Change-Id: Id27ba5093b88519c00acbc43ab8a991a671a9f51 --- tests/dlfcn_test.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/tests/dlfcn_test.cpp b/tests/dlfcn_test.cpp index 0ec46634c..4901d50d2 100644 --- a/tests/dlfcn_test.cpp +++ b/tests/dlfcn_test.cpp @@ -310,12 +310,7 @@ TEST(dlfcn, ifunc) { dlclose(handle); } -// ld.gold for arm produces incorrect binary (see http://b/27930475 for details) -#if defined(__arm__) -TEST(dlfcn, KNOWN_FAILURE_ON_BIONIC(ifunc_ctor_call)) { -#else TEST(dlfcn, ifunc_ctor_call) { -#endif typedef const char* (*fn_ptr)(); void* handle = dlopen("libtest_ifunc.so", RTLD_NOW); @@ -330,12 +325,7 @@ TEST(dlfcn, ifunc_ctor_call) { dlclose(handle); } -// ld.gold for arm produces incorrect binary (see http://b/27930475 for details) -#if defined(__arm__) -TEST(dlfcn, KNOWN_FAILURE_ON_BIONIC(ifunc_ctor_call_rtld_lazy)) { -#else TEST(dlfcn, ifunc_ctor_call_rtld_lazy) { -#endif typedef const char* (*fn_ptr)(); void* handle = dlopen("libtest_ifunc.so", RTLD_LAZY); -- 2.11.0