From c6889a6430e0819bb3d62fc1d40af68d4289ee8a Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Wed, 1 Oct 2014 08:33:54 -0400 Subject: [PATCH] e2fsprogs: add large_file to base mkfs features large_file (> 2G) support has been around since at least kernel 2.4; mkfs of any sufficiently large filesystem sets it "accidentally" when the resize inode exceeds 2G. This leaves very small filesystems lacking the feature, which potentially changes their behavior & codepaths the first time a > 2G file gets written. There's really no reason to be making fresh filesystems which strive to keep compatibility with 10 year old kernels; just enable large_file at mkfs time. This is particularly obvious for ext4 fielsystems, which set huge_file by default, but not necessarily large_file. If old-kernel compatibility is desired, mke2fs.conf can be modified locally to remove the feature. Signed-off-by: Eric Sandeen Signed-off-by: Theodore Ts'o --- misc/mke2fs.c | 2 +- misc/mke2fs.conf.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/misc/mke2fs.c b/misc/mke2fs.c index c9f5810a..a14e62e5 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -1873,7 +1873,7 @@ profile_error: tmp = NULL; if (fs_param.s_rev_level != EXT2_GOOD_OLD_REV) { tmp = get_string_from_profile(fs_types, "base_features", - "sparse_super,filetype,resize_inode,dir_index"); + "sparse_super,large_file,filetype,resize_inode,dir_index"); edit_feature(tmp, &fs_param.s_feature_compat); free(tmp); diff --git a/misc/mke2fs.conf.in b/misc/mke2fs.conf.in index 0871f777..47f59cce 100644 --- a/misc/mke2fs.conf.in +++ b/misc/mke2fs.conf.in @@ -1,5 +1,5 @@ [defaults] - base_features = sparse_super,filetype,resize_inode,dir_index,ext_attr + base_features = sparse_super,large_file,filetype,resize_inode,dir_index,ext_attr default_mntopts = acl,user_xattr enable_periodic_fsck = 0 blocksize = 4096 -- 2.11.0