From c8c2827993204207ca70a93f62f233fbe81b97ef Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Fri, 21 Nov 2008 00:12:10 +0000 Subject: [PATCH] Implement ComputeLatency for MachineInstr ScheduleDAGs. Factor some of the latency computation logic out of the SDNode ScheduleDAG code into a TargetInstrItineraries helper method to help with this. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@59761 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/CodeGen/ScheduleDAGInstrs.h | 4 ++++ include/llvm/Target/TargetInstrItineraries.h | 18 ++++++++++++++++++ lib/CodeGen/ScheduleDAGInstrs.cpp | 11 ++++++++++- lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp | 16 +++++++++------- 4 files changed, 41 insertions(+), 8 deletions(-) diff --git a/include/llvm/CodeGen/ScheduleDAGInstrs.h b/include/llvm/CodeGen/ScheduleDAGInstrs.h index 703c5b0876e..cc2cb0f3922 100644 --- a/include/llvm/CodeGen/ScheduleDAGInstrs.h +++ b/include/llvm/CodeGen/ScheduleDAGInstrs.h @@ -53,6 +53,10 @@ namespace llvm { /// input. virtual void BuildSchedUnits(); + /// ComputeLatency - Compute node latency. + /// + virtual void ComputeLatency(SUnit *SU); + virtual MachineBasicBlock *EmitSchedule(); /// Schedule - Order nodes according to selected style, filling diff --git a/include/llvm/Target/TargetInstrItineraries.h b/include/llvm/Target/TargetInstrItineraries.h index 1a5f46b1500..18931ea7fb4 100644 --- a/include/llvm/Target/TargetInstrItineraries.h +++ b/include/llvm/Target/TargetInstrItineraries.h @@ -73,6 +73,24 @@ struct InstrItineraryData { unsigned StageIdx = Itineratries[ItinClassIndx].Last; return Stages + StageIdx; } + + /// getLatency - Return the scheduling latency of the given class. A + /// simple latency value for an instruction is an over-simplification + /// for some architectures, but it's a reasonable first approximation. + /// + unsigned getLatency(unsigned ItinClassIndx) const { + // If the target doesn't provide latency information, use a simple + // non-zero default value for all instructions. + if (isEmpty()) + return 1; + + // Just sum the cycle count for each stage. + unsigned Latency = 0; + for (const InstrStage *IS = begin(ItinClassIndx), *E = end(ItinClassIndx); + IS != E; ++IS) + Latency += IS->Cycles; + return Latency; + } }; diff --git a/lib/CodeGen/ScheduleDAGInstrs.cpp b/lib/CodeGen/ScheduleDAGInstrs.cpp index b6bc44e849e..06d8ed9b25d 100644 --- a/lib/CodeGen/ScheduleDAGInstrs.cpp +++ b/lib/CodeGen/ScheduleDAGInstrs.cpp @@ -50,7 +50,7 @@ void ScheduleDAGInstrs::BuildSchedUnits() { assert(TRI->isPhysicalRegister(Reg) && "Virtual register encountered!"); std::vector &UseList = Uses[Reg]; SUnit *&Def = Defs[Reg]; - // Optionally add output and anti dependences + // Optionally add output and anti dependences. if (Def && Def != SU) Def->addPred(SU, /*isCtrl=*/true, /*isSpecial=*/false, /*PhyReg=*/Reg, Cost); @@ -102,6 +102,15 @@ void ScheduleDAGInstrs::BuildSchedUnits() { } } +void ScheduleDAGInstrs::ComputeLatency(SUnit *SU) { + const InstrItineraryData &InstrItins = TM.getInstrItineraryData(); + + // Compute the latency for the node. We use the sum of the latencies for + // all nodes flagged together into this SUnit. + SU->Latency = + InstrItins.getLatency(SU->getInstr()->getDesc().getSchedClass()); +} + void ScheduleDAGInstrs::dumpNode(const SUnit *SU) const { SU->getInstr()->dump(); } diff --git a/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp b/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp index 9d32d9afac5..91a8294e1d4 100644 --- a/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp +++ b/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp @@ -193,15 +193,17 @@ void ScheduleDAGSDNodes::ComputeLatency(SUnit *SU) { } SU->Latency = 0; - for (SDNode *N = SU->getNode(); N; N = N->getFlaggedNode()) { + bool SawMachineOpcode = false; + for (SDNode *N = SU->getNode(); N; N = N->getFlaggedNode()) if (N->isMachineOpcode()) { - unsigned SchedClass = TII->get(N->getMachineOpcode()).getSchedClass(); - const InstrStage *S = InstrItins.begin(SchedClass); - const InstrStage *E = InstrItins.end(SchedClass); - for (; S != E; ++S) - SU->Latency += S->Cycles; + SawMachineOpcode = true; + SU->Latency += + InstrItins.getLatency(TII->get(N->getMachineOpcode()).getSchedClass()); } - } + + // Ensure that CopyToReg and similar nodes have a non-zero latency. + if (!SawMachineOpcode) + SU->Latency = 1; } /// CountResults - The results of target nodes have register or immediate -- 2.11.0