From ca7fac9a2938d9ef996b8629bbb3c62a17c256e5 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Tue, 21 Jul 2015 19:57:43 +0000 Subject: [PATCH] Make printValue a member function. We were already passing 3 values it can get from ELFDumper. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242829 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/llvm-readobj/ELFDumper.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tools/llvm-readobj/ELFDumper.cpp b/tools/llvm-readobj/ELFDumper.cpp index 44df3a8def5..787b485972a 100644 --- a/tools/llvm-readobj/ELFDumper.cpp +++ b/tools/llvm-readobj/ELFDumper.cpp @@ -75,6 +75,7 @@ private: void printRelocations(const Elf_Shdr *Sec); void printRelocation(const Elf_Shdr *Sec, typename ELFO::Elf_Rela Rel); + void printValue(uint64_t Type, uint64_t Value); const ELFO *Obj; }; @@ -967,8 +968,8 @@ static const char *getDynamicString(const ELFFile &O, uint64_t Value) { } template -static void printValue(const ELFFile *O, uint64_t Type, uint64_t Value, - bool Is64, raw_ostream &OS) { +void ELFDumper::printValue(uint64_t Type, uint64_t Value) { + raw_ostream &OS = W.getOStream(); switch (Type) { case DT_PLTREL: if (Value == DT_REL) { @@ -1024,14 +1025,14 @@ static void printValue(const ELFFile *O, uint64_t Type, uint64_t Value, OS << Value << " (bytes)"; break; case DT_NEEDED: - OS << "SharedLibrary (" << getDynamicString(*O, Value) << ")"; + OS << "SharedLibrary (" << getDynamicString(*Obj, Value) << ")"; break; case DT_SONAME: - OS << "LibrarySoname (" << getDynamicString(*O, Value) << ")"; + OS << "LibrarySoname (" << getDynamicString(*Obj, Value) << ")"; break; case DT_RPATH: case DT_RUNPATH: - OS << getDynamicString(*O, Value); + OS << getDynamicString(*Obj, Value); break; case DT_MIPS_FLAGS: printFlags(Value, makeArrayRef(ElfDynamicDTMipsFlags), OS); @@ -1098,7 +1099,7 @@ void ELFDumper::printDynamicTable() { << " " << format(Is64 ? "0x%016" PRIX64 : "0x%08" PRIX64, Entry.getTag()) << " " << format("%-21s", getTypeString(Entry.getTag())); - printValue(Obj, Entry.getTag(), Entry.getVal(), Is64, OS); + printValue(Entry.getTag(), Entry.getVal()); OS << "\n"; } -- 2.11.0