From cdd7d2254c1409b9364623bcbd90daa56e44682f Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Fri, 24 Nov 2017 20:29:04 +0000 Subject: [PATCH] Recommit r318963 "[APInt] Don't print debug messages from the APInt knuth division algorithm by default" The previous commit had the condition in the do/while backwards. Debug builds currently print out low level details of the Knuth division algorithm when -debug is used. This information isn't useful in most cases and just adds noise to the log. This adds a new preprocessor flag to enable the prints in the knuth division code in APInt. Differential Revision: https://reviews.llvm.org/D40404 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@318966 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/APInt.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/Support/APInt.cpp b/lib/Support/APInt.cpp index c558ddd8216..1ea6319acfa 100644 --- a/lib/Support/APInt.cpp +++ b/lib/Support/APInt.cpp @@ -1252,6 +1252,14 @@ static void KnuthDiv(uint32_t *u, uint32_t *v, uint32_t *q, uint32_t* r, // b denotes the base of the number system. In our case b is 2^32. const uint64_t b = uint64_t(1) << 32; +// The DEBUG macros here tend to be spam in the debug output if you're not +// debugging this code. Disable them unless KNUTH_DEBUG is defined. +#pragma push_macro("DEBUG") +#ifndef KNUTH_DEBUG +#undef DEBUG +#define DEBUG(X) do {} while (false) +#endif + DEBUG(dbgs() << "KnuthDiv: m=" << m << " n=" << n << '\n'); DEBUG(dbgs() << "KnuthDiv: original:"); DEBUG(for (int i = m+n; i >=0; i--) dbgs() << " " << u[i]); @@ -1391,6 +1399,8 @@ static void KnuthDiv(uint32_t *u, uint32_t *v, uint32_t *q, uint32_t* r, DEBUG(dbgs() << '\n'); } DEBUG(dbgs() << '\n'); + +#pragma pop_macro("DEBUG") } void APInt::divide(const WordType *LHS, unsigned lhsWords, const WordType *RHS, -- 2.11.0