From ce58046673bfd18656fd94a6612a250f31036dce Mon Sep 17 00:00:00 2001 From: Doris Ling Date: Fri, 14 Apr 2017 14:04:32 -0700 Subject: [PATCH] Check if singleLineTitle attribute is set for the preference. Only call setSingleLine() on the preference title if the attribute is set. Bug: 37328004 Test: manual Change-Id: Ia95230cd08feaf8213cb5917c105d070eb30c11c --- core/java/android/preference/Preference.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/java/android/preference/Preference.java b/core/java/android/preference/Preference.java index d3adce73582e..7496cb28f046 100644 --- a/core/java/android/preference/Preference.java +++ b/core/java/android/preference/Preference.java @@ -135,6 +135,7 @@ public class Preference implements Comparable { private boolean mDependencyMet = true; private boolean mParentDependencyMet = true; private boolean mRecycleEnabled = true; + private boolean mHasSingleLineTitleAttr; private boolean mSingleLineTitle = true; private boolean mIconSpaceReserved; @@ -303,6 +304,7 @@ public class Preference implements Comparable { case com.android.internal.R.styleable.Preference_singleLineTitle: mSingleLineTitle = a.getBoolean(attr, mSingleLineTitle); + mHasSingleLineTitleAttr = true; break; case com.android.internal.R.styleable.Preference_iconSpaceReserved: @@ -609,7 +611,9 @@ public class Preference implements Comparable { if (!TextUtils.isEmpty(title)) { titleView.setText(title); titleView.setVisibility(View.VISIBLE); - titleView.setSingleLine(mSingleLineTitle); + if (mHasSingleLineTitleAttr) { + titleView.setSingleLine(mSingleLineTitle); + } } else { titleView.setVisibility(View.GONE); } -- 2.11.0