From ce74de46dd2b1ca040bc5d2e17af64832bc0b633 Mon Sep 17 00:00:00 2001 From: Dale Johannesen Date: Sun, 25 Feb 2007 18:31:31 +0000 Subject: [PATCH] cosmetic changes from review of last patch. obvious git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@34598 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/ARMConstantIslandPass.cpp | 4 ++-- lib/Target/ARM/README.txt | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/Target/ARM/ARMConstantIslandPass.cpp b/lib/Target/ARM/ARMConstantIslandPass.cpp index 422e0e4cb71..8fe8167abaf 100644 --- a/lib/Target/ARM/ARMConstantIslandPass.cpp +++ b/lib/Target/ARM/ARMConstantIslandPass.cpp @@ -558,7 +558,7 @@ MachineBasicBlock *ARMConstantIslands::SplitBlockBeforeInstr(MachineInstr *MI) { return NewBB; } -//// OffsetIsInRange - Checks whether UserOffset is within MaxDisp of +/// OffsetIsInRange - Checks whether UserOffset is within MaxDisp of /// TrialOffset. bool ARMConstantIslands::OffsetIsInRange(unsigned UserOffset, unsigned TrialOffset, unsigned MaxDisp, bool NegativeOK) { @@ -631,7 +631,7 @@ static bool BBIsJumpedOver(MachineBasicBlock *MBB) { void ARMConstantIslands::AdjustBBOffsetsAfter(MachineBasicBlock *BB, int delta) { MachineFunction::iterator MBBI = BB->getParent()->end(); - for(int i=BB->getNumber()+1; i<=prior(MBBI)->getNumber(); i++) + for(unsigned i=BB->getNumber()+1; igetParent()->getNumBlockIDs(); i++) BBOffsets[i] += delta; } diff --git a/lib/Target/ARM/README.txt b/lib/Target/ARM/README.txt index 8f80b79fc33..9f285812a89 100644 --- a/lib/Target/ARM/README.txt +++ b/lib/Target/ARM/README.txt @@ -24,8 +24,9 @@ things that can be done: 1. When there isn't an existing water, the current MBB is split right after the use. It would be profitable to look farther forward, especially on Thumb, where negative offsets won't work. -Now it will put the island at the end of the block if that is in range. If it -is not in range things still work as above, which is poor on Thumb. +(Partially fixed: it will put the island at the end of the block if that is +in range. If it is not in range things still work as above, which is poor on +Thumb.) 2. There may be some advantage to trying to be smarter about the initial placement, rather than putting everything at the end. -- 2.11.0