From cedacefd70cfa9ad219dcb15113fbe8a9a71c087 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Fri, 4 Mar 2016 08:18:47 -0500 Subject: [PATCH] Api Review: NotificationManager.Policy Bug: 27365873 Change-Id: Ie53a410d53f430fa90f24d95a885be150a3d66aa --- api/current.txt | 2 +- api/system-current.txt | 2 +- api/test-current.txt | 2 +- core/java/android/app/NotificationManager.java | 29 +++++++++++++++++++------- 4 files changed, 24 insertions(+), 11 deletions(-) diff --git a/api/current.txt b/api/current.txt index 755033860e67..8d59b6179f77 100644 --- a/api/current.txt +++ b/api/current.txt @@ -5258,7 +5258,7 @@ package android.app { } public static class NotificationManager.Policy implements android.os.Parcelable { - ctor public deprecated NotificationManager.Policy(int, int, int); + ctor public NotificationManager.Policy(int, int, int); ctor public NotificationManager.Policy(int, int, int, int); method public int describeContents(); method public static java.lang.String priorityCategoriesToString(int); diff --git a/api/system-current.txt b/api/system-current.txt index 2b809b8eb369..1b835fe96bad 100644 --- a/api/system-current.txt +++ b/api/system-current.txt @@ -5390,7 +5390,7 @@ package android.app { } public static class NotificationManager.Policy implements android.os.Parcelable { - ctor public deprecated NotificationManager.Policy(int, int, int); + ctor public NotificationManager.Policy(int, int, int); ctor public NotificationManager.Policy(int, int, int, int); method public int describeContents(); method public static java.lang.String priorityCategoriesToString(int); diff --git a/api/test-current.txt b/api/test-current.txt index d0e900717b04..b70b68f24693 100644 --- a/api/test-current.txt +++ b/api/test-current.txt @@ -5258,7 +5258,7 @@ package android.app { } public static class NotificationManager.Policy implements android.os.Parcelable { - ctor public deprecated NotificationManager.Policy(int, int, int); + ctor public NotificationManager.Policy(int, int, int); ctor public NotificationManager.Policy(int, int, int, int); method public int describeContents(); method public static java.lang.String priorityCategoriesToString(int); diff --git a/core/java/android/app/NotificationManager.java b/core/java/android/app/NotificationManager.java index 057a4e943971..16aee786d80c 100644 --- a/core/java/android/app/NotificationManager.java +++ b/core/java/android/app/NotificationManager.java @@ -662,7 +662,7 @@ public class NotificationManager /** * Notification policy configuration. Represents user-preferences for notification - * filtering and prioritization. + * filtering. */ public static class Policy implements android.os.Parcelable { /** Reminder notifications are prioritized. */ @@ -707,13 +707,13 @@ public class NotificationManager */ public static final int SUPPRESSED_EFFECTS_UNSET = -1; /** - * Whether notification suppressed by DND should not interruption visually when the screen - * is off. + * Whether notifications suppressed by DND should not interrupt visually (e.g. with + * notification lights or by turning the screen on) when the screen is off. */ public static final int SUPPRESSED_EFFECT_SCREEN_OFF = 1 << 0; /** - * Whether notification suppressed by DND should not interruption visually when the screen - * is on. + * Whether notifications suppressed by DND should not interrupt visually when the screen + * is on (e.g. by peeking onto the screen). */ public static final int SUPPRESSED_EFFECT_SCREEN_ON = 1 << 1; @@ -728,13 +728,27 @@ public class NotificationManager */ public final int suppressedVisualEffects; - - @Deprecated + /** + * Constructs a policy for Do Not Disturb priority mode behavior. + * + * @param priorityCategories bitmask of categories of notifications that can bypass DND. + * @param priorityCallSenders which callers can bypass DND. + * @param priorityMessageSenders which message senders can bypass DND. + */ public Policy(int priorityCategories, int priorityCallSenders, int priorityMessageSenders) { this(priorityCategories, priorityCallSenders, priorityMessageSenders, SUPPRESSED_EFFECTS_UNSET); } + /** + * Constructs a policy for Do Not Disturb priority mode behavior. + * + * @param priorityCategories bitmask of categories of notifications that can bypass DND. + * @param priorityCallSenders which callers can bypass DND. + * @param priorityMessageSenders which message senders can bypass DND. + * @param suppressedVisualEffects which visual interruptions should be suppressed from + * notifications that are filtered by DND. + */ public Policy(int priorityCategories, int priorityCallSenders, int priorityMessageSenders, int suppressedVisualEffects) { this.priorityCategories = priorityCategories; @@ -865,7 +879,6 @@ public class NotificationManager return new Policy[size]; } }; - } /** -- 2.11.0