From d02a9a798cef58361f0fc37a929e5c30a945b94d Mon Sep 17 00:00:00 2001 From: Alex Lorenz Date: Wed, 22 Jul 2015 21:07:04 +0000 Subject: [PATCH] MIR Parser: Extract the MDNode parsing code into a separate method. NFC. This change would allow the machine instruction parser to reuse this method when parsing the metadata node for the machine instruction's debug location property. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242934 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/MIRParser/MIParser.cpp | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/CodeGen/MIRParser/MIParser.cpp b/lib/CodeGen/MIRParser/MIParser.cpp index 212996bfaf5..edb4259fea7 100644 --- a/lib/CodeGen/MIRParser/MIParser.cpp +++ b/lib/CodeGen/MIRParser/MIParser.cpp @@ -112,6 +112,7 @@ public: bool parseConstantPoolIndexOperand(MachineOperand &Dest); bool parseJumpTableIndexOperand(MachineOperand &Dest); bool parseExternalSymbolOperand(MachineOperand &Dest); + bool parseMDNode(MDNode *&Node); bool parseMetadataOperand(MachineOperand &Dest); bool parseCFIOffset(int &Offset); bool parseCFIOperand(MachineOperand &Dest); @@ -576,7 +577,7 @@ bool MIParser::parseExternalSymbolOperand(MachineOperand &Dest) { return false; } -bool MIParser::parseMetadataOperand(MachineOperand &Dest) { +bool MIParser::parseMDNode(MDNode *&Node) { assert(Token.is(MIToken::exclaim)); auto Loc = Token.location(); lex(); @@ -589,7 +590,15 @@ bool MIParser::parseMetadataOperand(MachineOperand &Dest) { if (NodeInfo == IRSlots.MetadataNodes.end()) return error(Loc, "use of undefined metadata '!" + Twine(ID) + "'"); lex(); - Dest = MachineOperand::CreateMetadata(NodeInfo->second.get()); + Node = NodeInfo->second.get(); + return false; +} + +bool MIParser::parseMetadataOperand(MachineOperand &Dest) { + MDNode *Node = nullptr; + if (parseMDNode(Node)) + return true; + Dest = MachineOperand::CreateMetadata(Node); return false; } -- 2.11.0