From d6e493f6499c3be4a0a5af14eb433dec2ab725d3 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Tue, 29 Jul 2014 09:50:04 -0400 Subject: [PATCH] Fix issue with pin prompt. The PIN prompt would reappear if the pin screen had been rotated 90 degrees before a user hit cancel/ok. Change-Id: Ia5f93aa7a857d46ba95775c85344fa9ff28a4a6b --- .../android/settings/RestrictedSettingsFragment.java | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/src/com/android/settings/RestrictedSettingsFragment.java b/src/com/android/settings/RestrictedSettingsFragment.java index 8e88b30735..142a42c225 100644 --- a/src/com/android/settings/RestrictedSettingsFragment.java +++ b/src/com/android/settings/RestrictedSettingsFragment.java @@ -54,7 +54,6 @@ public class RestrictedSettingsFragment extends SettingsPreferenceFragment { // If the restriction PIN is entered correctly. private boolean mChallengeSucceeded; private boolean mChallengeRequested; - private boolean mScreenToggledOff; private UserManager mUserManager; private RestrictionsManager mRestrictionsManager; @@ -68,7 +67,6 @@ public class RestrictedSettingsFragment extends SettingsPreferenceFragment { if (!mChallengeRequested) { mChallengeSucceeded = false; mChallengeRequested = false; - mScreenToggledOff = true; } } }; @@ -93,19 +91,11 @@ public class RestrictedSettingsFragment extends SettingsPreferenceFragment { if (icicle != null) { mChallengeSucceeded = icicle.getBoolean(KEY_CHALLENGE_SUCCEEDED, false); mChallengeRequested = icicle.getBoolean(KEY_CHALLENGE_REQUESTED, false); - } else { - mChallengeSucceeded = false; - mChallengeRequested = false; } - mScreenToggledOff = false; IntentFilter offFilter = new IntentFilter(Intent.ACTION_SCREEN_OFF); offFilter.addAction(Intent.ACTION_USER_PRESENT); getActivity().registerReceiver(mScreenOffReceiver, offFilter); - - if (shouldBeProviderProtected(mRestrictionKey)) { - ensurePin(); - } } @Override @@ -121,11 +111,9 @@ public class RestrictedSettingsFragment extends SettingsPreferenceFragment { @Override public void onResume() { super.onResume(); - if (mScreenToggledOff) { - mScreenToggledOff = false; - if(shouldBeProviderProtected(mRestrictionKey)) { - ensurePin(); - } + + if (shouldBeProviderProtected(mRestrictionKey)) { + ensurePin(); } } -- 2.11.0