From dbdf4107cb5b3a56d6a62be94500d6b8664e6ab3 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Mon, 7 Mar 2016 00:13:09 +0000 Subject: [PATCH] Revert r130657, "Windows/DynamicLibrary.inc: Clean up ELM_Callback. We may check the decl instead of the versions of individual libraries." We may assume the type of 1st argument as PCSTR in PENUMLOADED_MODULES_CALLBACK. PSTR was in the ancient mingw32. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@262810 91177308-0d34-0410-b5e6-96231b3b80d8 --- cmake/config-ix.cmake | 15 --------------- include/llvm/Config/config.h.cmake | 3 --- lib/Support/Windows/DynamicLibrary.inc | 2 +- lib/Support/Windows/Signals.inc | 2 +- 4 files changed, 2 insertions(+), 20 deletions(-) diff --git a/cmake/config-ix.cmake b/cmake/config-ix.cmake index 2bbd15e29ff..dd96b5c3091 100755 --- a/cmake/config-ix.cmake +++ b/cmake/config-ix.cmake @@ -451,21 +451,6 @@ else() set(HAVE_DIA_SDK 0) endif( MSVC ) -if( PURE_WINDOWS ) - CHECK_CXX_SOURCE_COMPILES(" - #include - #include - extern \"C\" void foo(PENUMLOADED_MODULES_CALLBACK); - extern \"C\" void foo(BOOL(CALLBACK*)(PCSTR,ULONG_PTR,ULONG,PVOID)); - int main(){return 0;}" - HAVE_ELMCB_PCSTR) - if( HAVE_ELMCB_PCSTR ) - set(WIN32_ELMCB_PCSTR "PCSTR") - else() - set(WIN32_ELMCB_PCSTR "PSTR") - endif() -endif( PURE_WINDOWS ) - # FIXME: Signal handler return type, currently hardcoded to 'void' set(RETSIGTYPE void) diff --git a/include/llvm/Config/config.h.cmake b/include/llvm/Config/config.h.cmake index b08796aad7a..40520e29995 100644 --- a/include/llvm/Config/config.h.cmake +++ b/include/llvm/Config/config.h.cmake @@ -555,9 +555,6 @@ /* Define to 1 if your declares `struct tm'. */ #undef TM_IN_SYS_TIME -/* Type of 1st arg on ELM Callback */ -#cmakedefine WIN32_ELMCB_PCSTR ${WIN32_ELMCB_PCSTR} - /* Define to `int' if does not define. */ #undef pid_t diff --git a/lib/Support/Windows/DynamicLibrary.inc b/lib/Support/Windows/DynamicLibrary.inc index 17418b015c7..050689483de 100644 --- a/lib/Support/Windows/DynamicLibrary.inc +++ b/lib/Support/Windows/DynamicLibrary.inc @@ -45,7 +45,7 @@ static bool loadDebugHelp(void) { } static BOOL CALLBACK -ELM_Callback(WIN32_ELMCB_PCSTR ModuleName, DWORD64 ModuleBase, +ELM_Callback(PCSTR ModuleName, DWORD64 ModuleBase, ULONG ModuleSize, PVOID UserContext) { OpenedHandles->insert((HMODULE)ModuleBase); return TRUE; diff --git a/lib/Support/Windows/Signals.inc b/lib/Support/Windows/Signals.inc index f40ca72996a..552bbff5b0c 100644 --- a/lib/Support/Windows/Signals.inc +++ b/lib/Support/Windows/Signals.inc @@ -241,7 +241,7 @@ struct FindModuleData { }; } -static BOOL CALLBACK findModuleCallback(WIN32_ELMCB_PCSTR ModuleName, +static BOOL CALLBACK findModuleCallback(PCSTR ModuleName, DWORD64 ModuleBase, ULONG ModuleSize, void *VoidData) { FindModuleData *Data = (FindModuleData*)VoidData; -- 2.11.0