From dc7b42129565127b957e5d31949d874128a6202e Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Tue, 20 Sep 2022 07:50:24 +0300 Subject: [PATCH] warn when no data is provided but result is requested via QCryptographicHash::result() Signed-off-by: Ivailo Monev --- src/network/kernel/qcryptographichash.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/network/kernel/qcryptographichash.cpp b/src/network/kernel/qcryptographichash.cpp index 753c86394..4af6c1f77 100644 --- a/src/network/kernel/qcryptographichash.cpp +++ b/src/network/kernel/qcryptographichash.cpp @@ -258,7 +258,8 @@ bool QCryptographicHash::addData(QIODevice* device) */ QByteArray QCryptographicHash::result() const { - if (!d->rehash) { + if (Q_UNLIKELY(!d->rehash)) { + qWarning("QCryptographicHash::result called without any data"); return QByteArray(); } @@ -292,6 +293,7 @@ QByteArray QCryptographicHash::result() const } } + Q_UNREACHABLE(); return QByteArray(); } @@ -341,6 +343,7 @@ QByteArray QCryptographicHash::hash(const QByteArray &data, QCryptographicHash:: } } + Q_UNREACHABLE(); return QByteArray(); } -- 2.11.0