From deb338ee1849d227ba106f707fb53c0f18b49518 Mon Sep 17 00:00:00 2001 From: Grace Kloba Date: Fri, 28 Aug 2009 16:29:07 -0700 Subject: [PATCH] Fix the crash with sites having youtube video. It doesn't crash while loading. It crashes when you leave the site. frame->view() returns m_view.get(). So we don't want to call adoptRef which will cause a deref. I verified that when you leave the page, the new widget is removed. --- WebKit/android/WebCoreSupport/FrameLoaderClientAndroid.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WebKit/android/WebCoreSupport/FrameLoaderClientAndroid.cpp b/WebKit/android/WebCoreSupport/FrameLoaderClientAndroid.cpp index c9e712ed8..74b62dda3 100644 --- a/WebKit/android/WebCoreSupport/FrameLoaderClientAndroid.cpp +++ b/WebKit/android/WebCoreSupport/FrameLoaderClientAndroid.cpp @@ -961,7 +961,7 @@ WTF::PassRefPtr FrameLoaderClientAndroid::createPlugin( loadDataIntoFrame(frame.get(), KURL("file:///android_asset/webkit/"), String(), s); // Transfer ownership to a local refptr. - WTF::RefPtr widget = adoptRef(frame->view()); + WTF::RefPtr widget(frame->view()); return widget.release(); } return NULL; -- 2.11.0