From e1bbed21f1f442a047a4035516e067be484d8c47 Mon Sep 17 00:00:00 2001 From: Andreas Gampe Date: Wed, 20 May 2015 13:55:00 -0700 Subject: [PATCH] ART: Blacklist CFI test for non-compiled run-tests The test expects Java frames on the stack. Change-Id: I37914ad6a3c82264ee189492611469928a786f67 --- test/Android.run-test.mk | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/test/Android.run-test.mk b/test/Android.run-test.mk index 986276dc0..f27938f18 100644 --- a/test/Android.run-test.mk +++ b/test/Android.run-test.mk @@ -264,10 +264,12 @@ TEST_ART_BROKEN_FALLBACK_RUN_TESTS := \ 117-nopatchoat \ 118-noimage-dex2oat \ 119-noimage-patchoat \ + 137-cfi \ 138-duplicate-classes-check2 # This test fails without an image. TEST_ART_BROKEN_NO_IMAGE_RUN_TESTS := \ + 137-cfi \ 138-duplicate-classes-check ifneq (,$(filter no-dex2oat,$(PREBUILD_TYPES))) @@ -294,9 +296,13 @@ endif TEST_ART_BROKEN_FALLBACK_RUN_TESTS := +# 137: +# This test unrolls and expects managed frames, but tracing means we run the interpreter. +# 802: # This test dynamically enables tracing to force a deoptimization. This makes the test meaningless # when already tracing, and writes an error message that we do not want to check for. TEST_ART_BROKEN_TRACING_RUN_TESTS := \ + 137-cfi \ 802-deoptimization ifneq (,$(filter trace,$(TRACE_TYPES))) @@ -324,6 +330,7 @@ TEST_ART_BROKEN_NDEBUG_TESTS := \ 119-noimage-patchoat \ 131-structural-change \ 137-cfi \ + 139-register-natives \ 454-get-vreg \ 455-set-vreg \ 457-regs \ @@ -338,6 +345,19 @@ endif TEST_ART_BROKEN_NDEBUG_TESTS := +# Known broken tests for the interpreter. +# CFI unwinding expects managed frames. +TEST_ART_BROKEN_INTERPRETER_RUN_TESTS := \ + 137-cfi + +ifneq (,$(filter interpreter,$(COMPILER_TYPES))) + ART_TEST_KNOWN_BROKEN += $(call all-run-test-names,$(TARGET_TYPES),$(RUN_TYPES),$(PREBUILD_TYPES), \ + interpreter,$(RELOCATE_TYPES),$(TRACE_TYPES),$(GC_TYPES),$(JNI_TYPES), \ + $(IMAGE_TYPES),$(PICTEST_TYPES),$(DEBUGGABLE_TYPES),$(TEST_ART_BROKEN_INTERPRETER_RUN_TESTS),$(ALL_ADDRESS_SIZES)) +endif + +TEST_ART_BROKEN_INTERPRETER_RUN_TESTS := + # Known broken tests for the default compiler (Quick). TEST_ART_BROKEN_DEFAULT_RUN_TESTS := \ 457-regs @@ -429,7 +449,9 @@ endif TEST_ART_BROKEN_OPTIMIZING_DEBUGGABLE_RUN_TESTS := # Tests that should fail in the read barrier configuration. -TEST_ART_BROKEN_READ_BARRIER_RUN_TESTS := +# 137: Read barrier forces interpreter. Cannot run this with the interpreter. +TEST_ART_BROKEN_READ_BARRIER_RUN_TESTS := \ + 137-cfi ifeq ($(ART_USE_READ_BARRIER),true) ART_TEST_KNOWN_BROKEN += $(call all-run-test-names,$(TARGET_TYPES),$(RUN_TYPES),$(PREBUILD_TYPES), \ -- 2.11.0